[animations] Clarify that onClosed is called before transition#10400
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Nov 14, 2025
Merged
[animations] Clarify that onClosed is called before transition#10400auto-submit[bot] merged 3 commits intoflutter:mainfrom
auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
github-actions
bot
added
p: animations
triage-framework
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for OpenContainer.onClosed to clarify that the callback is executed at the start of the closing transition, not at the end. The change correctly reflects the component's behavior. The version in pubspec.yaml and the CHANGELOG.md have been updated accordingly. I have one suggestion to make the documentation even more explicit.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
hannah-hyj
added
the
autosubmit
loic-sharma
reviewed
Nov 14, 2025
Comment on lines
+193
to
+194
| /// Called when the container is popped. This is called at the start of the | ||
| /// closing transition. |
Member
There was a problem hiding this comment.
Suggested change
| /// Called when the container is popped. This is called at the start of the | |
| /// closing transition. | |
| /// Called when the container was popped and will return to the closed state. | |
| /// | |
| /// This is called at the start of the closing transition. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 17, 2025
flutter/packages@799b62c...ce44ebb 2025-11-17 [email protected] Kgp bulk update (flutter/packages#10412) 2025-11-16 [email protected] [camera_avfoundation] Wrappers swift migration - part 3 (flutter/packages#10293) 2025-11-15 [email protected] [ci] Update Flutter version for `release` (flutter/packages#10425) 2025-11-15 [email protected] Manual roll Flutter from c3f2704 to 9b5ad80 (2 revisions) (flutter/packages#10435) 2025-11-14 [email protected] Manual roll Flutter from ee23168 to c3f2704 (5 revisions) (flutter/packages#10433) 2025-11-14 [email protected] [ci] Remove mustache_template from allowed external deps (flutter/packages#10427) 2025-11-14 [email protected] [animations] Clarify that onClosed is called before transition (flutter/packages#10400) 2025-11-14 [email protected] [web_benchmarks] Report correct expected metrics for wasm (flutter/packages#10236) 2025-11-13 [email protected] [google_maps_flutter] Set properties before adding maps objects (flutter/packages#10347) 2025-11-13 [email protected] Roll Flutter (stable) from a0e9b9d to b45fa18 (3 revisions) (flutter/packages#10420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
flutter/packages@799b62c...ce44ebb 2025-11-17 [email protected] Kgp bulk update (flutter/packages#10412) 2025-11-16 [email protected] [camera_avfoundation] Wrappers swift migration - part 3 (flutter/packages#10293) 2025-11-15 [email protected] [ci] Update Flutter version for `release` (flutter/packages#10425) 2025-11-15 [email protected] Manual roll Flutter from c3f2704 to 9b5ad80 (2 revisions) (flutter/packages#10435) 2025-11-14 [email protected] Manual roll Flutter from ee23168 to c3f2704 (5 revisions) (flutter/packages#10433) 2025-11-14 [email protected] [ci] Remove mustache_template from allowed external deps (flutter/packages#10427) 2025-11-14 [email protected] [animations] Clarify that onClosed is called before transition (flutter/packages#10400) 2025-11-14 [email protected] [web_benchmarks] Report correct expected metrics for wasm (flutter/packages#10236) 2025-11-13 [email protected] [google_maps_flutter] Set properties before adding maps objects (flutter/packages#10347) 2025-11-13 [email protected] Roll Flutter (stable) from a0e9b9d to b45fa18 (3 revisions) (flutter/packages#10420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
flutter/packages@799b62c...ce44ebb 2025-11-17 [email protected] Kgp bulk update (flutter/packages#10412) 2025-11-16 [email protected] [camera_avfoundation] Wrappers swift migration - part 3 (flutter/packages#10293) 2025-11-15 [email protected] [ci] Update Flutter version for `release` (flutter/packages#10425) 2025-11-15 [email protected] Manual roll Flutter from c3f2704 to 9b5ad80 (2 revisions) (flutter/packages#10435) 2025-11-14 [email protected] Manual roll Flutter from ee23168 to c3f2704 (5 revisions) (flutter/packages#10433) 2025-11-14 [email protected] [ci] Remove mustache_template from allowed external deps (flutter/packages#10427) 2025-11-14 [email protected] [animations] Clarify that onClosed is called before transition (flutter/packages#10400) 2025-11-14 [email protected] [web_benchmarks] Report correct expected metrics for wasm (flutter/packages#10236) 2025-11-13 [email protected] [google_maps_flutter] Set properties before adding maps objects (flutter/packages#10347) 2025-11-13 [email protected] Roll Flutter (stable) from a0e9b9d to b45fa18 (3 revisions) (flutter/packages#10420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@799b62c...ce44ebb 2025-11-17 [email protected] Kgp bulk update (flutter/packages#10412) 2025-11-16 [email protected] [camera_avfoundation] Wrappers swift migration - part 3 (flutter/packages#10293) 2025-11-15 [email protected] [ci] Update Flutter version for `release` (flutter/packages#10425) 2025-11-15 [email protected] Manual roll Flutter from c3f2704 to 9b5ad80 (2 revisions) (flutter/packages#10435) 2025-11-14 [email protected] Manual roll Flutter from ee23168 to c3f2704 (5 revisions) (flutter/packages#10433) 2025-11-14 [email protected] [ci] Remove mustache_template from allowed external deps (flutter/packages#10427) 2025-11-14 [email protected] [animations] Clarify that onClosed is called before transition (flutter/packages#10400) 2025-11-14 [email protected] [web_benchmarks] Report correct expected metrics for wasm (flutter/packages#10236) 2025-11-13 [email protected] [google_maps_flutter] Set properties before adding maps objects (flutter/packages#10347) 2025-11-13 [email protected] Roll Flutter (stable) from a0e9b9d to b45fa18 (3 revisions) (flutter/packages#10420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the documentation for
OpenContainer.onClosedto clarify that it is called at the start of the closing transition, not at the end.Resolves flutter/flutter#178314
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
This PR only affects comments/documentation. ↩