Skip to content

Updated AGP and KGP to align with flutter/flutter templates#10423

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
jesswrd:update-agp-kgp
Mar 6, 2026
Merged

Updated AGP and KGP to align with flutter/flutter templates#10423
auto-submit[bot] merged 3 commits intoflutter:mainfrom
jesswrd:update-agp-kgp

Conversation

@jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Nov 14, 2025

Updated the example app agp and kgp versions to match the template defaults.

AGP 8.11.0 --> 8.11.1
KGP 2.2.0 --> 2.2.20

Potentially Addresses flutter/flutter#178908

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@github-actions github-actions bot added p: webview_flutter p: video_player p: url_launcher p: shared_preferences p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package p: interactive_media_ads Plugin for IMA SDK p: flutter_svg p: google_fonts triage-framework Should be looked at in framework triage triage-engine Should be looked at in engine triage labels Nov 14, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Android Gradle Plugin (AGP) and Kotlin Gradle Plugin (KGP) versions across numerous settings.gradle files. The changes correctly align the versions with the flutter/flutter templates. However, I've identified several files where the indentation of the updated lines is inconsistent with the surrounding code within the plugins block. I have added comments with suggestions to correct the formatting for better code maintainability.

Comment on lines +22 to +23
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.

  id "com.android.application" version "8.11.1" apply false
  id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Comment on lines +22 to +23
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.

  id "com.android.application" version "8.11.1" apply false
  id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Comment on lines +22 to +23
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.

  id "com.android.application" version "8.11.1" apply false
  id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Comment on lines +22 to +23
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.

  id "com.android.application" version "8.11.1" apply false
  id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Comment on lines +22 to +23
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.

  id "com.android.application" version "8.11.1" apply false
  id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Comment on lines +22 to +23
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.

  id "com.android.application" version "8.11.1" apply false
  id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Comment on lines +22 to +23
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for these lines is inconsistent with the rest of the plugins block. Please use 2 spaces for indentation to match the surrounding lines.

  id "com.android.application" version "8.11.1" apply false
  id "org.jetbrains.kotlin.android" version "2.2.20" apply false

Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some spacing got messed up but lgtm outside that

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mavenCentral()
gradlePluginPortal()
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting that the indent (2 vs 4 spaces) of this block isn't consistent across files. I don't think it's worth worrying about though, since once we migrate everything to Kotlin it'll be autoformatted anyway.

@jesswrd
Copy link
Contributor Author

jesswrd commented Nov 25, 2025

The exact warnings I'm trying to suppress/resolve: flutter/flutter#178908

@justinmc
Copy link
Contributor

@jesswrd FYI there are some failures here, would you be able to fix them so we can get this landed?

@stuartmorgan-g
Copy link
Collaborator

The failures here are the warning that was fixed in #10632, so merging in main to see if this passes now.

@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2026
@auto-submit auto-submit bot merged commit 1e0338b into flutter:main Mar 6, 2026
81 checks passed
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 9, 2026
flutter/packages@fe3de64...c717018

2026-03-09 [email protected] [pigeon] Support
javax.annotation.Generated annotation in Kotlin generator
(flutter/packages#10961)
2026-03-09 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump gradle-wrapper from 8.13 to 9.4.0 in
/packages/path_provider/path_provider/example/android/app
(flutter/packages#11206)
2026-03-09 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.1 to 9.1.0 in
/packages/shared_preferences/shared_preferences_android/example/android/app
(flutter/packages#11208)
2026-03-09 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump gradle-wrapper from 8.13 to 9.4.0 in
/packages/path_provider/path_provider_android/example/android/app
(flutter/packages#11207)
2026-03-06 [email protected] [various] Plugin Gradle pre-Kotlin
standardization (flutter/packages#11173)
2026-03-06 [email protected] Updated AGP and KGP to align with
flutter/flutter templates (flutter/packages#10423)
2026-03-06 [email protected] Roll Flutter from
d3dd774 to d182143 (33 revisions) (flutter/packages#11191)
2026-03-06 [email protected]
[google_maps_flutter] Add Advanced Markers support
(flutter/packages#7882)
2026-03-06 [email protected]
[in_app_purchase]Fixes StoreKit 2 purchase flow to send
cancelled/pending/unverified results to purchaseStream.
(flutter/packages#10736)
2026-03-06 [email protected] [flutter_svg] Update README with an
example to scale images (flutter/packages#10547)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
xxxOVALxxx pushed a commit to xxxOVALxxx/flutter that referenced this pull request Mar 10, 2026
…er#183396)

flutter/packages@fe3de64...c717018

2026-03-09 [email protected] [pigeon] Support
javax.annotation.Generated annotation in Kotlin generator
(flutter/packages#10961)
2026-03-09 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump gradle-wrapper from 8.13 to 9.4.0 in
/packages/path_provider/path_provider/example/android/app
(flutter/packages#11206)
2026-03-09 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.1 to 9.1.0 in
/packages/shared_preferences/shared_preferences_android/example/android/app
(flutter/packages#11208)
2026-03-09 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump gradle-wrapper from 8.13 to 9.4.0 in
/packages/path_provider/path_provider_android/example/android/app
(flutter/packages#11207)
2026-03-06 [email protected] [various] Plugin Gradle pre-Kotlin
standardization (flutter/packages#11173)
2026-03-06 [email protected] Updated AGP and KGP to align with
flutter/flutter templates (flutter/packages#10423)
2026-03-06 [email protected] Roll Flutter from
d3dd774 to d182143 (33 revisions) (flutter/packages#11191)
2026-03-06 [email protected]
[google_maps_flutter] Add Advanced Markers support
(flutter/packages#7882)
2026-03-06 [email protected]
[in_app_purchase]Fixes StoreKit 2 purchase flow to send
cancelled/pending/unverified results to purchaseStream.
(flutter/packages#10736)
2026-03-06 [email protected] [flutter_svg] Update README with an
example to scale images (flutter/packages#10547)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants