Updated AGP and KGP to align with flutter/flutter templates#10423
Updated AGP and KGP to align with flutter/flutter templates#10423auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Android Gradle Plugin (AGP) and Kotlin Gradle Plugin (KGP) versions across numerous settings.gradle files. The changes correctly align the versions with the flutter/flutter templates. However, I've identified several files where the indentation of the updated lines is inconsistent with the surrounding code within the plugins block. I have added comments with suggestions to correct the formatting for better code maintainability.
packages/extension_google_sign_in_as_googleapis_auth/example/android/settings.gradle
Show resolved
Hide resolved
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
| id "com.android.application" version "8.11.1" apply false | ||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false |
There was a problem hiding this comment.
gmackall
left a comment
There was a problem hiding this comment.
looks like some spacing got messed up but lgtm outside that
8cbc0ca to
6bc6894
Compare
| mavenCentral() | ||
| gradlePluginPortal() | ||
| } | ||
| } |
There was a problem hiding this comment.
It's interesting that the indent (2 vs 4 spaces) of this block isn't consistent across files. I don't think it's worth worrying about though, since once we migrate everything to Kotlin it'll be autoformatted anyway.
|
The exact warnings I'm trying to suppress/resolve: flutter/flutter#178908 |
|
@jesswrd FYI there are some failures here, would you be able to fix them so we can get this landed? |
|
The failures here are the warning that was fixed in #10632, so merging in |
flutter/packages@fe3de64...c717018 2026-03-09 [email protected] [pigeon] Support javax.annotation.Generated annotation in Kotlin generator (flutter/packages#10961) 2026-03-09 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump gradle-wrapper from 8.13 to 9.4.0 in /packages/path_provider/path_provider/example/android/app (flutter/packages#11206) 2026-03-09 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.9.1 to 9.1.0 in /packages/shared_preferences/shared_preferences_android/example/android/app (flutter/packages#11208) 2026-03-09 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump gradle-wrapper from 8.13 to 9.4.0 in /packages/path_provider/path_provider_android/example/android/app (flutter/packages#11207) 2026-03-06 [email protected] [various] Plugin Gradle pre-Kotlin standardization (flutter/packages#11173) 2026-03-06 [email protected] Updated AGP and KGP to align with flutter/flutter templates (flutter/packages#10423) 2026-03-06 [email protected] Roll Flutter from d3dd774 to d182143 (33 revisions) (flutter/packages#11191) 2026-03-06 [email protected] [google_maps_flutter] Add Advanced Markers support (flutter/packages#7882) 2026-03-06 [email protected] [in_app_purchase]Fixes StoreKit 2 purchase flow to send cancelled/pending/unverified results to purchaseStream. (flutter/packages#10736) 2026-03-06 [email protected] [flutter_svg] Update README with an example to scale images (flutter/packages#10547) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#183396) flutter/packages@fe3de64...c717018 2026-03-09 [email protected] [pigeon] Support javax.annotation.Generated annotation in Kotlin generator (flutter/packages#10961) 2026-03-09 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump gradle-wrapper from 8.13 to 9.4.0 in /packages/path_provider/path_provider/example/android/app (flutter/packages#11206) 2026-03-09 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.9.1 to 9.1.0 in /packages/shared_preferences/shared_preferences_android/example/android/app (flutter/packages#11208) 2026-03-09 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump gradle-wrapper from 8.13 to 9.4.0 in /packages/path_provider/path_provider_android/example/android/app (flutter/packages#11207) 2026-03-06 [email protected] [various] Plugin Gradle pre-Kotlin standardization (flutter/packages#11173) 2026-03-06 [email protected] Updated AGP and KGP to align with flutter/flutter templates (flutter/packages#10423) 2026-03-06 [email protected] Roll Flutter from d3dd774 to d182143 (33 revisions) (flutter/packages#11191) 2026-03-06 [email protected] [google_maps_flutter] Add Advanced Markers support (flutter/packages#7882) 2026-03-06 [email protected] [in_app_purchase]Fixes StoreKit 2 purchase flow to send cancelled/pending/unverified results to purchaseStream. (flutter/packages#10736) 2026-03-06 [email protected] [flutter_svg] Update README with an example to scale images (flutter/packages#10547) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updated the example app agp and kgp versions to match the template defaults.
AGP 8.11.0 --> 8.11.1
KGP 2.2.0 --> 2.2.20
Potentially Addresses flutter/flutter#178908
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3