Updates pigeon dependencies to the latest version (^26.1.0)#10448
Updates pigeon dependencies to the latest version (^26.1.0)#10448
Conversation
Unblocks the flutter/flutter pub package roll, which requires support for analyzer >= 8.0.0. Bumps versions for `in_app_purchase_android`, `in_app_purchase_storekit`, `path_provider_android`, `url_launcher_android`, `url_launcher_ios`, `url_launcher_linux`, `url_launcher_macos`, and `url_launcher_windows`, which are the packages currently causing dependency resolution to fail due to their outdated pigeon dependencies.
bkonyi
requested review from
LongCatIsLooong,
LouiseHsu,
bparrishMines,
camsim99,
gmackall,
hellohuanlin,
jesswrd,
mboetger,
okorohelijah,
reidbaker,
robert-ancell,
stuartmorgan-g,
tarrinneal and
vashworth
as code owners
github-actions
bot
added
p: video_player
p: url_launcher
p: shared_preferences
p: interactive_media_ads
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the pigeon dependency to ^26.1.0 across multiple packages. This is a necessary update to support newer versions of the analyzer package.
However, a critical step is missing: after updating the pigeon dependency, the corresponding generated files (.g.dart, .kt, etc.) must be regenerated. The current generated files still show older pigeon versions in their headers. For example, packages/camera/camera_android/lib/src/messages.g.dart still indicates it was generated with v22.4.1. Please run the pigeon generator for all affected packages to ensure the generated code is up-to-date with the new dependency version.
Additionally, there's a formatting issue in one of the pubspec.yaml files that makes it invalid, which I've commented on separately.
|
Pigeon is a code generator, so updates should regenerate the code as well. I can prep a full PR (we have a repo tool command, |
Yeah, I was in the process of rerunning the generator for the repo. I seem to have some static errors now in a few of the projects though. |
|
I have a version of this that does the whole repo at #10450 since I already had it underway when I saw that you'd pushed fixes for the errors you mentioned. |
|
Closing in favor of #10450 |
3 participants
Unblocks the flutter/flutter pub package roll, which requires support for analyzer >= 8.0.0.
Bumps versions for
in_app_purchase_android,in_app_purchase_storekit,path_provider_android,url_launcher_android,url_launcher_ios,url_launcher_linux,url_launcher_macos, andurl_launcher_windows, which are the packages currently causing dependency resolution to fail due to their outdated pigeon dependencies.