[google_maps_flutter_web] Add Cloud MapStyle color scheme support for web by martyfuhry · Pull Request #10471 · flutter/packages

martyfuhry · 2025-11-19T16:10:44Z

This PR adds web support for setting Cloud-based map style color schemes in google_maps_flutter_web.

GoogleMap(
  cloudMapId: cloudMapId,
  colorScheme: MapColorScheme.light, // OR .dark, .followSystem
  // ...
);

In mobile platforms, the system brightness is always used to select the correct cloud-style variant (light or dark). Currently in web, the cloud-style variant is always light. With this change, we set colorScheme by default to .followSystem in order to achieve parity with the mobile platforms.

Additionally, we expose the field for web-only use to override the default behavior. I do not believe that the mobile SDKs expose similar methods, so the value is ignored by them.

Fixes flutter/flutter#176445

What this PR adds

Serialization of Cloud MapStyle color scheme fields to JS MapOptions

Changelog

Updated CHANGELOG.md following repository CHANGELOG style guidelines.

Pre-Review Checklist

flutter-dashboard · 2025-11-19T16:10:48Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

martyfuhry · 2025-11-19T16:15:34Z

I didn't add any tests since this is a thin JS-interop passthrough with no added business logic. Please let me know if this PR is not exempt.

gemini-code-assist

Code Review

This pull request adds support for MapColorScheme for cloud-based map styles on the web, achieving parity with mobile platforms. The changes are well-structured, adding the new colorScheme property through the widget, platform interface, and web implementation layers.

My main feedback is regarding testing. The PR introduces new logic but doesn't include corresponding tests. It would be beneficial to add unit tests for the new colorScheme property in MapConfiguration and the GoogleMap widget, as well as for the conversion logic in google_maps_flutter_web. This will help ensure the new feature is working as expected and prevent future regressions.

I have one minor suggestion to modernize the Dart code in the conversion logic.

gemini-code-assist · 2025-11-19T16:16:07Z

packages/google_maps_flutter/google_maps_flutter_web/lib/src/convert.dart

+gmaps.ColorScheme? _gmapTypeColorSchemeForPluginColor(MapColorScheme? scheme) {
+  // Guard clause for null
+  if (scheme == null) {
+    return null;
+  }
+
+  // Map to gmaps.ColorScheme
+  switch (scheme) {
+    case MapColorScheme.dark:
+      return gmaps.ColorScheme.DARK;
+    case MapColorScheme.light:
+      return gmaps.ColorScheme.LIGHT;
+    case MapColorScheme.followSystem:
+      return gmaps.ColorScheme.FOLLOW_SYSTEM;
+  }
+}


This function can be made more concise by using a switch expression, which is available in this version of Dart. This improves readability by reducing boilerplate.

gmaps.ColorScheme? _gmapTypeColorSchemeForPluginColor(MapColorScheme? scheme) { return switch (scheme) { MapColorScheme.dark => gmaps.ColorScheme.DARK, MapColorScheme.light => gmaps.ColorScheme.LIGHT, MapColorScheme.followSystem => gmaps.ColorScheme.FOLLOW_SYSTEM, null => null, }; }

I had considered this, but decided to match the style of the below _gmapTypeIDForPluginType function, which uses the older more verbose switch syntax.

stuartmorgan-g · 2025-11-19T16:38:42Z

Thanks for the contribution! You’ve checked boxes in the PR checklist above that are not reflected in this PR, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the state of the PR as posted reflects the checklist please feel free to mark it as ready for review.

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[...]

All existing and new tests are passing.

The PR does not follow our process for changing federated plugins, so most of the CI is failing.

I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.

I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.

This PR changes three packages, but only does this for one of them.

stuartmorgan-g · 2025-11-19T16:39:53Z

I didn't add any tests since this is a thin JS-interop passthrough with no added business logic. Please let me know if this PR is not exempt.

Which of the documented exemption reasons do you believe this falls under?

The entire plugin is a wrapper that does passthrough to the underlying SDK; it's not clear to me what about this part you believe is exempt from testing, or why it wouldn't matter if this passthrough were to break in the future.

stuartmorgan-g · 2025-11-19T16:42:46Z

completing parity with the existing mobile implementations

Could you elaborate on what you mean here? The issue description sounds like this is a web-only option, but if similar functionality exists for mobile we should be abstracting that rather than adding a web-only parameter.

martyfuhry · 2025-11-19T17:14:47Z

Thank you for the detailed feedback @stuartmorgan-g! It is very helpful.

The PR does not follow our process for changing federated plugins, so most of the CI is failing.

Thank you for the link! I did not fully understand the federated plugin flow. I'll follow the documented process and update all affected packages accordingly.

This PR changes three packages, but only does this for one of them.

Got it. I will update the other packages pubspec.yaml and CHANGELOG.md, as well.

Could you elaborate on what you mean here? The issue description sounds like this is a web-only option, but if similar functionality exists for mobile we should be abstracting that rather than adding a web-only parameter.

Right, great point. The mobile platforms always uses your default system brightness and applies that automatically to select the brightness-aware cloud-style variant (light or dark). I don't believe the mobile SDKs expose an equivalent parameter, so this is currently a web-only feature of the cloud styling system. To reduce the ambiguity, I could make the colorScheme default to .followSystem in order to unify the three platforms' behavior.

Which of the documented exemption reasons do you believe this falls under?

You are right, this change doesn't fall under any of the documented automatic exemptions. I'll add a small test that covers this passthrough so that future changes do not accidentally regress the issue.

I appreciate your thorough review and guidance. Thanks for helping me with this submission.

…en pubspec bump

…map initialization. Adds comments to MapColorScheme enum.

martyfuhry · 2025-11-20T22:17:31Z

I believe the last remaining test failure is the expected one from docs.

I have updated the PR description with the new changes.

I have also added a unit test.

Please let me if there is anything I have done incorrectly or haven't completed. Thank you again for your instruction.

…n google_map

…s and android

martyfuhry · 2025-12-04T19:01:02Z

Thank you again @stuartmorgan-g for the thorough review. I have addressed all of your corrections and am resubmitting for review.

stuartmorgan-g

Two minor notes. Otherwise, this looks good to me, so once it has a second review from the web team it'll be ready to split into sub-PRs.

stuartmorgan-g · 2025-12-22T19:21:43Z

packages/google_maps_flutter/google_maps_flutter_web/lib/src/convert.dart

+    case MapColorScheme.followSystem:
+      return gmaps.ColorScheme.FOLLOW_SYSTEM;
+  }
+  // ignore: dead_code


This should have the same comment explaining why it's here as the code in the previous function.

stuartmorgan-g · 2025-12-22T19:22:22Z

packages/google_maps_flutter/google_maps_flutter_web/lib/src/convert.dart

+      return gmaps.ColorScheme.FOLLOW_SYSTEM;
+  }
+  // ignore: dead_code
+  return gmaps.ColorScheme.FOLLOW_SYSTEM;


Since this function has a nullable return value, the fallback should be null rather than a specific value.

stuartmorgan-g · 2026-02-03T19:24:46Z

From triage: @mdebbar Ping on the secondary review here.

mdebbar · 2026-02-11T17:44:02Z

packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart

    trafficEnabled: map.trafficEnabled,
    buildingsEnabled: map.buildingsEnabled,
-    mapId: map.cloudMapId,
+    cloudMapId: map.cloudMapId,


cloudMapId is deprecated, let's revert this back to mapId:

Suggested change

cloudMapId: map.cloudMapId,

mapId: map.cloudMapId,

stuartmorgan-g · 2026-03-18T13:59:44Z

Closing in favor of #11278, #11279, and #11280 since the Flutter team can't push updates to this PR to address the final feedback.

Thanks for the contribution!

…lutter#11278) Platform interface portion of flutter#10471 Part of flutter/flutter#176445 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…11279) Web portion of #10471, incorporating review feedback and some other minor cleanup. Part of flutter/flutter#176445 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…11280) App-facing portion of #10471, incorporating review feedback and some other minor cleanup. Fixes flutter/flutter#176445 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

martyfuhry added 4 commits November 19, 2025 09:31

Adds support for color scheme

9cb7faf

adds color scheme to exportrs

838a768

Renames to match naming convention

e8c04e6

Bumps version and updates changelog

5854d68

martyfuhry requested review from mdebbar and stuartmorgan-g as code owners November 19, 2025 16:10

github-actions bot added p: google_maps_flutter platform-web labels Nov 19, 2025

Merge branch 'main' into feat/web-colorscheme

f79f5c4

gemini-code-assist bot reviewed Nov 19, 2025

View reviewed changes

stuartmorgan-g added the triage-web Should be looked at in web triage label Nov 19, 2025

stuartmorgan-g marked this pull request as draft November 19, 2025 16:38

martyfuhry added 2 commits November 20, 2025 09:28

updates the pubspec.yaml files to have path-based dependency overrides

ca8153c

Updates pubspec.yaml of other touched plugins

c75420c

github-actions bot added platform-android platform-ios labels Nov 20, 2025

martyfuhry added 6 commits November 20, 2025 10:14

adds CHANGELOG entries to affected federated packages. Reverts mistak…

5d53e49

…en pubspec bump

Sets default color scheme to follow system and adds simple unit tests

24a65c4

Updates comment

ba0aa0c

Fixes unit test and adds comments to clarify setting color scheme at …

47ff935

…map initialization. Adds comments to MapColorScheme enum.

format tests

d513046

Ran the update-release-info tool to fix changelogs

5a03b72

martyfuhry marked this pull request as ready for review November 20, 2025 22:17

martyfuhry added 5 commits December 3, 2025 15:30

Makes colorscheme nullable, removes default setting, fixes comments i…

01e3dc8

…n google_map

Fixes minor version bump in pubspec and changelogs

4730f74

Resolves conflicts

3fde10c

Fixes comments and adds unit tests.

89e5820

Fixes comments. Adds fallthrough handling for color scheme enum mapping

2cc8021

martyfuhry force-pushed the feat/web-colorscheme branch from 12e3ed6 to 2cc8021 Compare December 3, 2025 20:45

fixes default color scheme null

51e97d1

martyfuhry requested a review from LongCatIsLooong as a code owner December 4, 2025 16:05

martyfuhry added 3 commits December 4, 2025 12:06

fixes google_maps version

17b73a0

fixing versioning

1b9b4a4

reverts remaining accidental clobbered changes from main rebase in io…

42aecea

…s and android

github-actions bot removed platform-android platform-ios labels Dec 4, 2025

Fixes the version mismatch in the changelog and pubspec

69f7b2b

martyfuhry requested a review from stuartmorgan-g December 4, 2025 19:01

stuartmorgan-g removed request for LongCatIsLooong, reidbaker and vashworth December 22, 2025 19:18

stuartmorgan-g reviewed Dec 22, 2025

View reviewed changes

mdebbar reviewed Feb 11, 2026

View reviewed changes

This was referenced Mar 18, 2026

[google_maps_flutter] Add color scheme support to platform interface #11278

Closed

[google_maps_flutter] Add color scheme support to web implementation #11279

Merged

[google_maps_flutter] Add color scheme support to app-facing package #11280

Merged

stuartmorgan-g closed this Mar 18, 2026

Conversation

martyfuhry commented Nov 19, 2025 • edited by stuartmorgan-g Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR adds

Changelog

Pre-Review Checklist

Uh oh!

flutter-dashboard bot commented Nov 19, 2025

Uh oh!

martyfuhry commented Nov 19, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

martyfuhry Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Nov 19, 2025

Uh oh!

stuartmorgan-g commented Nov 19, 2025

Uh oh!

stuartmorgan-g commented Nov 19, 2025

Uh oh!

martyfuhry commented Nov 19, 2025

Uh oh!

martyfuhry commented Nov 20, 2025

Uh oh!

martyfuhry commented Dec 4, 2025

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Feb 3, 2026

Uh oh!

mdebbar Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

martyfuhry commented Nov 19, 2025 •

edited by stuartmorgan-g

Loading

stuartmorgan-g Dec 22, 2025 •

edited

Loading