[ci] Adds repo checks in main branch for batch release by chunhtai · Pull Request #10485 · flutter/packages

chunhtai · 2025-11-21T00:53:42Z

This fixes main branch part of flutter/flutter#176433

The work left is adjusting cocoon to also run this check in release branch

The high level view of this pr.

Move ci_config.yaml and pending changelog parsing into thir own files and the parsed results are exposed as a getter method in RepositoryPackage so that it can be shared between branch_for_release, repo_package_info_check, and version_check
The format error of ci_config.yaml and changelog files are reported in repo_package_info_check. The other 2 assume they are correct formatted and throw directly if they are not.
update the version_check to be able to handle batch release package

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

chunhtai · 2025-11-21T18:55:24Z

script/tool/lib/src/version_check_command.dart

+        }
+      }
+    } else {
+      switch (versionState) {


no change to this part, just put the original code into the else case

chunhtai · 2025-11-21T20:58:13Z

script/tool/test/repo_package_info_check_command_test.dart

      expect(
        output,
        containsAll(<Matcher>[
-          contains('  Checking ci_config.yaml...'),


Removed additional print to be more in sync with all the check in repo_package_info

script/tool/lib/src/common/repository_package.dart

script/tool/lib/src/version_check_command.dart

chunhtai · 2025-12-05T22:54:31Z

packages/go_router/pending_changelogs/template.yaml

@@ -1,6 +0,0 @@
-# Use this file as template to draft a unreleased changelog file.


I have to delete this file because now the ci will check whether batch release is enabled if these file exists

script/tool/lib/src/version_check_command.dart

chunhtai · 2025-12-05T23:19:21Z

change since last review is in the second commit

stuartmorgan-g · 2025-12-09T17:51:30Z

script/tool/lib/src/common/pending_changelog_entry.dart

+///
+/// During a release (specifically the `update-changelogs` command), all
+/// pending entries are aggregated, the package version is updated based on the
+/// highest priority change, and `CHANGELOG.md` is updated.


Perfect, thanks!

script/tool/lib/src/common/repository_package.dart

script/tool/test/common/repository_package_test.dart

script/tool/lib/src/repo_package_info_check_command.dart

script/tool/lib/src/version_check_command.dart

stuartmorgan-g

LGTM

…tter/packages#10485)

flutter/packages@12eb764...d3f860d 2026-01-05 [email protected] [ci] Adds repo checks in main branch for batch release (flutter/packages#10485) 2026-01-05 [email protected] [ci] Pins github action commit hash (flutter/packages#10599) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This fixes main branch part of flutter/flutter#176433 The work left is adjusting cocoon to also run this check in release branch The high level view of this pr. 1. Move ci_config.yaml and pending changelog parsing into thir own files and the parsed results are exposed as a getter method in RepositoryPackage so that it can be shared between branch_for_release, repo_package_info_check, and version_check 2. The format error of ci_config.yaml and changelog files are reported in repo_package_info_check. The other 2 assume they are correct formatted and throw directly if they are not. 3. update the version_check to be able to handle batch release package ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

chunhtai changed the title ~~[ci] Adds repo checks for batch release~~ [ci] Adds repo checks in main branch for batch release Nov 21, 2025

chunhtai force-pushed the issues/176433 branch from 50bdfb2 to 98b36da Compare November 21, 2025 21:10

github-actions bot added p: go_router triage-framework Should be looked at in framework triage labels Nov 21, 2025

chunhtai commented Nov 21, 2025

View reviewed changes

chunhtai force-pushed the issues/176433 branch 3 times, most recently from 47627d5 to dd032aa Compare November 21, 2025 22:55

github-actions bot removed p: go_router triage-framework Should be looked at in framework triage labels Nov 21, 2025

chunhtai requested a review from stuartmorgan-g November 21, 2025 23:52

chunhtai marked this pull request as ready for review November 21, 2025 23:52

stuartmorgan-g requested changes Dec 3, 2025

View reviewed changes

chunhtai force-pushed the issues/176433 branch 3 times, most recently from 82cfcd6 to 2285870 Compare December 5, 2025 20:22

github-actions bot added p: go_router triage-framework Should be looked at in framework triage labels Dec 5, 2025

chunhtai commented Dec 5, 2025

View reviewed changes

chunhtai force-pushed the issues/176433 branch from 33a042d to fb0209c Compare December 5, 2025 23:16

chunhtai requested a review from stuartmorgan-g December 5, 2025 23:19

chunhtai force-pushed the issues/176433 branch 2 times, most recently from 1365946 to 2b68de2 Compare December 8, 2025 18:56

stuartmorgan-g requested changes Dec 9, 2025

View reviewed changes

chunhtai force-pushed the issues/176433 branch from 2b68de2 to 249a5ec Compare December 9, 2025 19:34

chunhtai requested a review from stuartmorgan-g December 9, 2025 19:46

chunhtai mentioned this pull request Dec 9, 2025

[batch-release] Step2 : Publish packages from the release branch #10459

Merged

11 tasks

chunhtai force-pushed the issues/176433 branch from 249a5ec to 659d47b Compare December 10, 2025 20:16

stuartmorgan-g approved these changes Dec 22, 2025

View reviewed changes

chunhtai added 3 commits January 5, 2026 10:17

[ci] Adds repo checks for batch release

897d7a2

everything before non batch check

eb321a7

addressing comments

8ed96a8

chunhtai force-pushed the issues/176433 branch from 659d47b to 8ed96a8 Compare January 5, 2026 18:17

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 5, 2026

auto-submit bot merged commit d3f860d into flutter:main Jan 5, 2026
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 6, 2026

d3f860dcd [ci] Adds repo checks in main branch for batch release (flu…

df74125

…tter/packages#10485)

engine-flutter-autoroll mentioned this pull request Jan 6, 2026

Roll Packages from 12eb764783f4 to d3f860dcd2dd (2 revisions) flutter/flutter#180581

Merged

		@@ -1,6 +0,0 @@
		# Use this file as template to draft a unreleased changelog file.

Conversation

chunhtai commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

chunhtai Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chunhtai Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chunhtai commented Dec 5, 2025

Uh oh!

stuartmorgan-g Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chunhtai commented Nov 21, 2025 •

edited

Loading