[in_app_purchase_storekit] Fix Xcode 26.2 analyzer warnings#10649
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Dec 19, 2025
Merged
[in_app_purchase_storekit] Fix Xcode 26.2 analyzer warnings#10649auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
11 tasks
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses three analyzer warnings from Xcode 26.2 by updating a preprocessor macro, removing an unused variable, and changing a mutable variable to a constant. The CHANGELOG.md has also been updated. One minor style issue regarding indentation has been pointed out for improvement.
...rchase/in_app_purchase_storekit/example/shared/RunnerTests/FIAPPaymentQueueDeleteTests.swift
Outdated
Show resolved
Hide resolved
LouiseHsu
reviewed
Dec 19, 2025
| plugin.purchase(id: "consumable", options: nil) { result in | ||
| switch result { | ||
| case .success(let purchase): | ||
| case .success(_): |
Contributor
There was a problem hiding this comment.
The tests are failing - Im guessing you might need to keep the "let purchase" because of IAP sandbox shennanigans. I think if you dont handle the VerificationResult it freaks out. Maybe we can do this instead
case .success(let purchase):
_ = purchase
Member
Author
There was a problem hiding this comment.
Weird, this test passes on Xcode 26.2 locally.
Member
Author
There was a problem hiding this comment.
And also passed on 16.4 locally...
Member
Author
There was a problem hiding this comment.
And it passed in CI when run a second time.
Contributor
There was a problem hiding this comment.
ugh the tests are flaky :( thats not good
Contributor
There was a problem hiding this comment.
jmagman
force-pushed
the
in-app-purchase-analyzer
branch
from
c8f9c1b to
150a2aa
Compare
LouiseHsu
approved these changes
Dec 19, 2025
jmagman
added
the
autosubmit
30 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 23, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 23, 2025
flutter/packages@f28cf2e...5e3a766 2025-12-19 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group across 1 directory with 2 updates (flutter/packages#10624) 2025-12-19 [email protected] [in_app_purchase_storekit] Fix Xcode 26.2 analyzer warnings (flutter/packages#10649) 2025-12-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 14 directories with 1 update (flutter/packages#10625) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ivan-vanyusho
pushed a commit
to ivan-vanyusho/packages
that referenced
this pull request
Jan 26, 2026
…10649) Seen in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8695102947197916049/+/u/Run_package_tests/native_test/stdout I opened in Xcode 26.2 and let it "Fix". ``` FIAPPaymentQueueDeleteTests.swift:87:7: warning: 'TARGET_OS_*' preprocessor macros are not available in Swift; use 'os(iOS)' instead #if TARGET_OS_IOS ^~~~~~~~~~~~~ ``` ``` InAppPurchaseStoreKit2PluginTests.swift:396:25: warning: immutable value 'purchase' was never used; consider replacing with '_' or removing it case .success(let purchase): ~~~~^~~~~~~~ _ ``` ``` TranslatorTests.swift:18:9: warning: variable 'map' was never mutated; consider changing to 'let' constant var map: [String: Any] = [ ~~~ ^ let ``` ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8695102947197916049/+/u/Run_package_tests/native_test/stdout
I opened in Xcode 26.2 and let it "Fix".
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3