Skip to content

[interactive_media_ads] Updates README to recommend that a single AdsLoader should be used per page#11103

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
bparrishMines:ima_loader_page
Feb 24, 2026
Merged

[interactive_media_ads] Updates README to recommend that a single AdsLoader should be used per page#11103
auto-submit[bot] merged 2 commits intoflutter:mainfrom
bparrishMines:ima_loader_page

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Feb 23, 2026

Addresses flutter/flutter#182012

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@bparrishMines bparrishMines changed the title Ima loader page [interactive_media_ads] Updates README to recommend that a single AdsLoader should be used per page Feb 23, 2026
@bparrishMines bparrishMines marked this pull request as ready for review February 23, 2026 19:48
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the CHANGELOG.md and README.md files to reflect a change in the recommended usage of AdsLoader, suggesting one instance per page instead of per application. It also updates the plugin version in pubspec.yaml, AdsRequestProxyApi.kt, and AdsRequestProxyAPIDelegate.swift to 0.3.0+11.

Comment on lines +1 to +4
## 0.3.0+11

* Updates `README` to recommend that a single `AdsLoader` should be used per page not for the entire
application.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The CHANGELOG entry is well-written and clearly describes the update to the README regarding AdsLoader usage. This adheres to the repository's guideline for updating CHANGELOG.md.

References
  1. Code should follow the guidance and principles described in the flutter/packages contribution guide, including updating CHANGELOG.md to add a description of the change, following repository CHANGELOG style. (link)

* [AdDisplayContainer][3]: A container object where ads are rendered.
* [AdsLoader][4]: Requests ads and handles events from ads request responses. You should only
instantiate one ads loader, which can be reused throughout the life of the application.
instantiate one ads loader at a time, which can be reused throughout the lifecycle of a page.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The update to the README.md clarifies the recommended usage of AdsLoader to be "one ads loader at a time, which can be reused throughout the lifecycle of a page." This is a good improvement for clarity and correctness.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2026
@auto-submit auto-submit bot merged commit 062c8d4 into flutter:main Feb 24, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 24, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Feb 24, 2026
flutter/packages@12b43a1...062c8d4

2026-02-24 [email protected]
[interactive_media_ads] Updates `README` to recommend that a single
`AdsLoader` should be used per page (flutter/packages#11103)
2026-02-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.webkit:webkit from 1.14.0 to 1.15.0 in
/packages/webview_flutter/webview_flutter_android/android
(flutter/packages#10986)
2026-02-23 [email protected] Roll Flutter from
91b2d41 to dad6f9d (20 revisions) (flutter/packages#11102)
2026-02-23 [email protected]
[google_maps_flutter_platform_interface] Add iOS warning for PinConfig
(flutter/packages#11100)
2026-02-23 [email protected] Roll Flutter (stable) from
44a626f to 90673a4 (10 revisions) (flutter/packages#11090)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ahmedsameha1 pushed a commit to ahmedsameha1/flutter that referenced this pull request Feb 27, 2026
…r#182839)

flutter/packages@12b43a1...062c8d4

2026-02-24 [email protected]
[interactive_media_ads] Updates `README` to recommend that a single
`AdsLoader` should be used per page (flutter/packages#11103)
2026-02-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.webkit:webkit from 1.14.0 to 1.15.0 in
/packages/webview_flutter/webview_flutter_android/android
(flutter/packages#10986)
2026-02-23 [email protected] Roll Flutter from
91b2d41 to dad6f9d (20 revisions) (flutter/packages#11102)
2026-02-23 [email protected]
[google_maps_flutter_platform_interface] Add iOS warning for PinConfig
(flutter/packages#11100)
2026-02-23 [email protected] Roll Flutter (stable) from
44a626f to 90673a4 (10 revisions) (flutter/packages#11090)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: interactive_media_ads Plugin for IMA SDK platform-android platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants