[webview_flutter] Remove usesCleartextTraffic#11124
[webview_flutter] Remove usesCleartextTraffic#11124auto-submit[bot] merged 9 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the deprecated android:usesCleartextTraffic attribute with the modern android:networkSecurityConfig in the example app's Android manifests. This change improves security by explicitly disabling cleartext traffic in release builds, while still allowing it in debug builds for testing purposes. The removal of the unused espresso dev dependency is also a good cleanup. I have one minor suggestion to improve clarity and consistency in the new network security configuration file.
...ew_flutter/webview_flutter/example/android/app/src/debug/res/xml/network_security_config.xml
Show resolved
Hide resolved
mboetger
added
override: no versioning needed
|
override changelog/versioning: configuration change |
mboetger
changed the title
...iew_flutter/webview_flutter/example/android/app/src/main/res/xml/network_security_config.xml
Outdated
Show resolved
Hide resolved
mboetger
added
the
autosubmit
flutter/packages@e1d0169...a27d7c5 2026-02-26 [email protected] [pigeon] Tidy GeneratorAdapters to be const, with getters instead of fields (flutter/packages#11131) 2026-02-26 [email protected] [webview_flutter] Remove usesCleartextTraffic (flutter/packages#11124) 2026-02-26 [email protected] [pigeon]: Correct comment references in doc comments (flutter/packages#11129) 2026-02-26 [email protected] [webview_flutter_android] Remove usesCleartextTraffic (flutter/packages#11122) 2026-02-26 [email protected] Roll Flutter from dad6f9d to b31548f (39 revisions) (flutter/packages#11116) 2026-02-26 [email protected] [espresso] Remove usesCleartextTraffic (flutter/packages#11125) 2026-02-26 [email protected] [pigeon] Use function types in order to avoid dynamic calls (flutter/packages#11130) 2026-02-26 [email protected] [shared_preferences] Revert androidx.datastore:datastore to 1.1.7 (flutter/packages#11128) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#183009) flutter/packages@e1d0169...a27d7c5 2026-02-26 [email protected] [pigeon] Tidy GeneratorAdapters to be const, with getters instead of fields (flutter/packages#11131) 2026-02-26 [email protected] [webview_flutter] Remove usesCleartextTraffic (flutter/packages#11124) 2026-02-26 [email protected] [pigeon]: Correct comment references in doc comments (flutter/packages#11129) 2026-02-26 [email protected] [webview_flutter_android] Remove usesCleartextTraffic (flutter/packages#11122) 2026-02-26 [email protected] Roll Flutter from dad6f9d to b31548f (39 revisions) (flutter/packages#11116) 2026-02-26 [email protected] [espresso] Remove usesCleartextTraffic (flutter/packages#11125) 2026-02-26 [email protected] [pigeon] Use function types in order to avoid dynamic calls (flutter/packages#11130) 2026-02-26 [email protected] [shared_preferences] Revert androidx.datastore:datastore to 1.1.7 (flutter/packages#11128) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Removes deprecated usesCleartextTraffic.
Addresses: flutter/flutter#182553
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).