[various] Convert plugin builds to Kotlin gradle#11172
[various] Convert plugin builds to Kotlin gradle#11172stuartmorgan-g wants to merge 37 commits intoflutter:mainfrom
Conversation
stuartmorgan-g
requested review from
bparrishMines,
camsim99,
gmackall,
jesswrd,
mboetger,
reidbaker and
tarrinneal
as code owners
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates a large number of Android plugin build files from Groovy to Kotlin DSL. The changes are mostly mechanical conversions and appear to be correct, preserving the original build logic. I've found one minor issue where a compiler option was dropped during the conversion in one of the test plugins, which I've commented on.
stuartmorgan-g
added
the
autosubmit
| kotlinOptions { | ||
| // This must match the Java version provided in compileOptions. | ||
| jvmTarget = JavaVersion.VERSION_17.toString() | ||
| } |
There was a problem hiding this comment.
The kotlin { compilerOptions { ... } } section on line 31 is the newer form of this.
| // The following Espresso dependency can be either "implementation" | ||
| // or "androidTestImplementation", depending on whether you want the | ||
| // dependency to appear on your APK's compile classpath or the test APK | ||
| // dependency to appear on your APK"s compile classpath or the test APK |
There was a problem hiding this comment.
this doesn't seem intentional
There was a problem hiding this comment.
Oops, I thought I fixed all of these. My vi record/playback for classpath standardization wasn't quite as precise as intended on the initial pass.
| kotlinOptions { | ||
| jvmTarget = JavaVersion.VERSION_17.toString() | ||
| } | ||
|
|
There was a problem hiding this comment.
here also, I saw that it was still in some of the new files
There was a problem hiding this comment.
Same. The new files should all have the new form rather than this.
stuartmorgan-g
removed
the
autosubmit
3 participants
Following up from #11169, this converts all the rest of the plugins in the repository to use Kotlin rather than Groovy for plugin build files. As with that PR, this does not change the example apps, only the plugin builds themselves.
Part of flutter/flutter#176065
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2