[pigeon] Produce a helpful error for bad method return type#11204
Merged
srawlins merged 6 commits intoflutter:mainfrom Mar 11, 2026
Merged
[pigeon] Produce a helpful error for bad method return type#11204srawlins merged 6 commits intoflutter:mainfrom
srawlins merged 6 commits intoflutter:mainfrom
Conversation
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves error handling in Pigeon by providing a more informative error message for methods with unexpected or missing return types, preventing null-pointer exceptions. The changes are accompanied by relevant tests. My review includes a suggestion to fix a typo in a variable name for better code clarity and maintainability.
tarrinneal
approved these changes
Mar 11, 2026
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
Good catch! Did you try to do this at some point and run across this failure?
Contributor
Author
|
No, I was just going through old bugs that seemed like they were related to types in Dart code. :D |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 11, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 11, 2026
flutter/packages@ee460d6...ecace66 2026-03-11 [email protected] [pigeon] Produce a helpful error for bad method return type (flutter/packages#11204) 2026-03-11 [email protected] [pigeon] Use hasLength and isEmpty in tests for better failure messages (flutter/packages#11205) 2026-03-11 [email protected] [rfw] Opt out of icon tree shaking (flutter/packages#11216) 2026-03-11 [email protected] [pigeon] Tidy imports and "ignore" comments (flutter/packages#11149) 2026-03-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.2.21 to 2.3.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#10984) 2026-03-11 [email protected] [pigeon] Improve casting and nullability-handling in generated code (flutter/packages#11163) 2026-03-10 [email protected] Roll Flutter from 2ec61af to 195ae7b (36 revisions) (flutter/packages#11222) 2026-03-10 [email protected] [vector_graphics] Respect BoxFit parameter with viewbox (flutter/packages#11012) 2026-03-10 [email protected] Add AI contribution guidelines to PR checklist (flutter/packages#11195) 2026-03-10 [email protected] [video_player] Optimize caption retrieval with binary search in VideoPlayerController (flutter/packages#8347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we encounter an unexpected (or missing) method return type, we now produce a meaningful error instead of a null-pointer exception.
Fixes flutter/flutter#92639
Pre-Review Checklist
[shared_preferences]///).