[pigeon] Use hasLength and isEmpty in tests for better failure messages#11205
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Mar 11, 2026
Merged
[pigeon] Use hasLength and isEmpty in tests for better failure messages#11205auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
Contributor
Author
|
This is test-excempt as it only affects tests, and I believe it is also version-bump-exempt for the same reason. |
tarrinneal
approved these changes
Mar 11, 2026
Contributor
tarrinneal
left a comment
There was a problem hiding this comment.
good change, @stuartmorgan-g for exemptions
Collaborator
|
Exemptions are only needed when bots are angry; both the test nag bot and the version/changelog CI check know these are exempt test files. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 11, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 11, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 11, 2026
flutter/packages@ee460d6...ecace66 2026-03-11 [email protected] [pigeon] Produce a helpful error for bad method return type (flutter/packages#11204) 2026-03-11 [email protected] [pigeon] Use hasLength and isEmpty in tests for better failure messages (flutter/packages#11205) 2026-03-11 [email protected] [rfw] Opt out of icon tree shaking (flutter/packages#11216) 2026-03-11 [email protected] [pigeon] Tidy imports and "ignore" comments (flutter/packages#11149) 2026-03-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.2.21 to 2.3.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#10984) 2026-03-11 [email protected] [pigeon] Improve casting and nullability-handling in generated code (flutter/packages#11163) 2026-03-10 [email protected] Roll Flutter from 2ec61af to 195ae7b (36 revisions) (flutter/packages#11222) 2026-03-10 [email protected] [vector_graphics] Respect BoxFit parameter with viewbox (flutter/packages#11012) 2026-03-10 [email protected] Add AI contribution guidelines to PR checklist (flutter/packages#11195) 2026-03-10 [email protected] [video_player] Optimize caption retrieval with binary search in VideoPlayerController (flutter/packages#8347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an expectation like
expect(foo.length, equals(0))fails, you just see a message like "7 is not 0." Changing these tests to useisEmptyandhasLength, likeexpect(foo, isEmpty), you'll instead see a much more useful message like "expected this thing to have 0 elements, but instead it was [a, b, c]."Pre-Review Checklist
[shared_preferences]///).