Skip to content

[various] iOS/macOS example project automigrations#11227

Merged
auto-submit[bot] merged 6 commits intoflutter:mainfrom
stuartmorgan-g:swiftpm-master-automigrations
Mar 12, 2026
Merged

[various] iOS/macOS example project automigrations#11227
auto-submit[bot] merged 6 commits intoflutter:mainfrom
stuartmorgan-g:swiftpm-master-automigrations

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Mar 11, 2026 •
edited
Loading

Builds all example apps on iOS and macOS using the current master (cccee58dbb09922259bf64cbe819b2e6c5949ef4), and checks in the results. The main goal of this PR is to pick up the auto-migration to the new Swift Package Manager integration that includes plugin dependencies as local SwiftPM project entries (for a much better development experience), but this picks up some other incidental changes as well in many projects:

  • Updating outdated deployment targets that are below the current Flutter minimums. master and stable current have the same minimums, so this doesn't incorrectly raise an requirements for the examples.
  • Removes some CocoaPods bits from the project file, but those will be automatically re-added for any non-SwiftPM build, so won't break local development or CI on stable without SwiftPM enabled.
  • UIScene support in flutter_svg, which should be effectively a no-op since that's not a plugin.
  • Minor Xcode internals like LastUpgradeCheck, which should be harmless.

macOS projects have been manually fixed to address the bug described here.

Fixes flutter/flutter#183474

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@stuartmorgan-g stuartmorgan-g removed triage-framework Should be looked at in framework triage triage-engine Should be looked at in engine triage labels Mar 11, 2026
@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review March 11, 2026 15:32
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Mar 11, 2026 •
edited
Loading

@vashworth I originally made this as a trial to see if there would be any surprises in CI, but since it all passed I vote we land it if everything looks good to you.

@stuartmorgan-g stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Mar 11, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 11, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automates the migration of iOS and macOS example projects across various packages. The changes primarily involve updating Xcode project settings, such as deployment targets and Xcode version checks. It also migrates projects from CocoaPods to Swift Package Manager, which involves removing CocoaPods-related build phases and adding SwiftPM package references. One notable issue was found regarding the relativePath for SwiftPM packages in macOS projects, which appears to be inconsistent with the fix described in the linked issue.

packages/google_fonts/example/macos/Runner.xcodeproj/project.pbxproj
/* Begin XCLocalSwiftPackageReference section */
781AD8BC2B33823900A9FFBB /* XCLocalSwiftPackageReference "FlutterGeneratedPluginSwiftPackage" */ = {
isa = XCLocalSwiftPackageReference;
relativePath = Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage;
Copy link

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The PR description mentions that macOS projects have been manually fixed to address the issue with relativePath for SwiftPM packages. However, this relativePath appears to be incorrect for macOS.

According to the linked issue comment, for macOS projects the correct path should be ephemeral/Packages/FlutterGeneratedPluginSwiftPackage.

This seems to apply to several other macOS projects in this PR as well. Could you please double-check this?

relativePath = ephemeral/Packages/FlutterGeneratedPluginSwiftPackage;

Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity: this is the project-level entry, which appears to be project-dir relative, not the files list entry under the Flutter group, which is explicitly marked as group-relative.

tarrinneal
tarrinneal approved these changes Mar 11, 2026
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely read every change in this pr and after careful deliberation have decided that I think it is good to land.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2026
@auto-submit auto-submit bot merged commit 02f231f into flutter:main Mar 12, 2026
81 checks passed
@stuartmorgan-g stuartmorgan-g deleted the swiftpm-master-automigrations branch March 12, 2026 15:33
@github-actions github-actions bot added triage-framework Should be looked at in framework triage triage-engine Should be looked at in engine triage labels Mar 12, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2026
@engine-flutter-autoroll
02f231f37 [various] iOS/macOS example project automigrations (flutter…
a4ea106 
…/packages#11227)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2026
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 12, 2026
@engine-flutter-autoroll
Roll Packages from ecace66e92c2 to 02f231f37676 (4 revisions) (#183594)
880c9eb 
flutter/packages@ecace66...02f231f

2026-03-12 [email protected] [various] iOS/macOS example project
automigrations (flutter/packages#11227)
2026-03-11 [email protected] [webview_flutter_wkwebview] Add support
for javaScriptCanOpenWindowsAutomatically (flutter/packages#10608)
2026-03-11 [email protected] [url_launcher] Disable flaky test
(flutter/packages#11229)
2026-03-11 [email protected] Roll Flutter from
195ae7b to 3f400d7 (13 revisions) (flutter/packages#11228)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong LongCatIsLooong is a code owner

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin is a code owner

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu LouiseHsu is a code owner

@okorohelijah okorohelijah Awaiting requested review from okorohelijah okorohelijah is a code owner

@domesticmouse domesticmouse Awaiting requested review from domesticmouse domesticmouse is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@Piinks Piinks Awaiting requested review from Piinks Piinks is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@chunhtai chunhtai Awaiting requested review from chunhtai chunhtai is a code owner

@hannah-hyj hannah-hyj Awaiting requested review from hannah-hyj hannah-hyj is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: animations p: camera p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_svg p: go_router p: google_fonts p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: interactive_media_ads Plugin for IMA SDK p: local_auth p: path_provider p: pigeon p: pointer_interceptor p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package p: url_launcher p: video_player p: webview_flutter platform-ios platform-macos triage-engine Should be looked at in engine triage triage-framework Should be looked at in framework triage triage-ios Should be looked at in iOS triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate 1P iOS/macOS Plugin example apps to use local package override

3 participants

@stuartmorgan-g @vashworth @tarrinneal