[url_launcher] Disable flaky test#11229
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Mar 11, 2026
Merged
Conversation
This test is flaking frequently under WASM. This is an initial attempt which disables just the one test, but since it's the first test it may be that every test in this file will flake. If that turns out to be the case, we will need to disable the whole package's testing under WASM instead. See flutter/flutter#182844
Collaborator
Author
|
Everything but the |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables a test in link_widget_test.dart that is reported to be flaky on WASM. My review suggests an improvement to conditionally skip the test only for WASM builds. This makes the fix more targeted and retains test coverage on other platforms where the test is stable.
| expect(anchor.getAttribute('target'), '_self'); | ||
| }, | ||
| // Flaky under WASM: https://github.com/flutter/flutter/issues/182844 | ||
| skip: true, |
There was a problem hiding this comment.
To avoid disabling this test on all platforms, it's better to skip it only on WASM where it is flaky. You can achieve this by using a compile-time constant to check for the WASM environment. This will keep the test active for other web renderers where it is not flaky.
Suggested change
| skip: true, | |
| skip: const bool.fromEnvironment('dart.library.wasm'), |
mdebbar
approved these changes
Mar 11, 2026
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
LGTM, thanks @stuartmorgan-g
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 12, 2026
flutter/packages@ecace66...02f231f 2026-03-12 [email protected] [various] iOS/macOS example project automigrations (flutter/packages#11227) 2026-03-11 [email protected] [webview_flutter_wkwebview] Add support for javaScriptCanOpenWindowsAutomatically (flutter/packages#10608) 2026-03-11 [email protected] [url_launcher] Disable flaky test (flutter/packages#11229) 2026-03-11 [email protected] Roll Flutter from 195ae7b to 3f400d7 (13 revisions) (flutter/packages#11228) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is flaking frequently under WASM. This is an initial attempt which disables just the one test, but since it's the first test it may be that every test in this file will flake. If that turns out to be the case, we will need to disable the whole package's testing under WASM instead.
See flutter/flutter#182844