Skip to content

[camera_avfoundation] Remove outdated TODO comment in messages.dart#11236

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
cdeil:rm-outdated-todo-in-camera-avfoundation-messages
Mar 17, 2026
Merged

[camera_avfoundation] Remove outdated TODO comment in messages.dart#11236
auto-submit[bot] merged 1 commit intoflutter:mainfrom
cdeil:rm-outdated-todo-in-camera-avfoundation-messages

Conversation

@cdeil
Copy link
Contributor

@cdeil cdeil commented Mar 12, 2026

The PR removes an outdated TODO code comment in the Pigeon messages.dart in camera_avfoundation.

@stuartmorgan-g - You already addressed it in 2024 here: 3584ddb#diff-ce4d13732a822cf36d7a1c574215e7974670567cd5667e2a1665c88ac5dc2615R163

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a TODO comment from the CameraApi definition in packages/camera/camera_avfoundation/pigeons/messages.dart. The removed comment indicated a need to make a generic type non-nullable.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an outdated TODO comment from the CameraApi class in packages/camera/camera_avfoundation/pigeons/messages.dart. This is a code cleanup and has no functional impact.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a TODO comment from the CameraApi class in packages/camera/camera_avfoundation/pigeons/messages.dart. The removed comment was related to making a generic type non-nullable.

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes CICD Run CI/CD labels Mar 12, 2026
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks, I thought I had done a final sweep of the entire repo for this issue number to make sure I caught everything.

@stuartmorgan-g stuartmorgan-g requested review from bparrishMines and tarrinneal and removed request for tarrinneal March 12, 2026 17:40
@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2026
@auto-submit auto-submit bot merged commit 70049bd into flutter:main Mar 17, 2026
81 checks passed
reidbaker pushed a commit that referenced this pull request Mar 17, 2026
…11236)

The PR removes an outdated `TODO` code comment in the Pigeon `messages.dart` in `camera_avfoundation`.

@stuartmorgan-g - You already addressed it in 2024 here: 3584ddb#diff-ce4d13732a822cf36d7a1c574215e7974670567cd5667e2a1665c88ac5dc2615R163

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 18, 2026
flutter/packages@a9d36fb...afa1a1c

2026-03-18 [email protected] Roll Flutter from
732e05d to d117642 (47 revisions) (flutter/packages#11276)
2026-03-18 [email protected] [google_maps_flutter] Add color
scheme support to platform interface (flutter/packages#11278)
2026-03-17 [email protected] [video_player] Regenerate iOS example
with Swift (flutter/packages#11275)
2026-03-17 [email protected] [camera_avfoundation] Remove
outdated TODO comment in messages.dart (flutter/packages#11236)
2026-03-17 [email protected] [web_benchmark] Fix tab connection for
newer versions of Chrome (flutter/packages#11266)
2026-03-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 14 directories
with 1 update (flutter/packages#11250)
2026-03-17 [email protected] [ci] Enable SwiftPM by default for
platform tests (flutter/packages#11271)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera platform-ios platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants