[ci] Enable SwiftPM by default for platform tests#11271
[ci] Enable SwiftPM by default for platform tests#11271auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
Rather than continue to plumb `--swift-package-manager` support into every command to make CI work on stable, just enable it at the machine level before running platform tests so that they all use Swift Package Manager, making `stable` and `master` act the same for these tasks. The build-all tests are not changed, as they continue to be the testbed for ensuring that plugins are usable by clients who are using CocoaPods. A recipe step runs `flutter config --clear-features` at the start of any bot's run, so this should not cause cross-task bot contamination.
|
I was missing at least 2-3 more commands (drive-examples, probably both native test and analyze), so rather than continue chasing them all down this flips the big switch. Wiring up |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables Swift Package Manager (SwiftPM) by default for CI platform tests on iOS and macOS. This is done by adding a new script, .ci/scripts/enable_swift_package_manager.sh, which runs flutter config --enable-swift-package-manager, and then invoking this script from the ios_platform_tests.yaml and macos_platform_tests.yaml configurations. The goal is to create consistency between stable and master channel test environments. My review includes one suggestion for macos_platform_tests.yaml to remove a redundant flag to fully align with the PR's stated goal.
stuartmorgan-g
added
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
1 similar comment
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
Rather than continue to plumb `--swift-package-manager` support into every command to make CI work on stable, just enable it at the machine level before running platform tests so that they all use Swift Package Manager, making `stable` and `master` act the same for these tasks. The build-all tests are not changed, as they continue to be the testbed for ensuring that plugins are usable by clients who are using CocoaPods. A recipe step runs `flutter config --clear-features` at the start of any bot's run, so this should not cause cross-task bot contamination.
flutter/packages@a9d36fb...afa1a1c 2026-03-18 [email protected] Roll Flutter from 732e05d to d117642 (47 revisions) (flutter/packages#11276) 2026-03-18 [email protected] [google_maps_flutter] Add color scheme support to platform interface (flutter/packages#11278) 2026-03-17 [email protected] [video_player] Regenerate iOS example with Swift (flutter/packages#11275) 2026-03-17 [email protected] [camera_avfoundation] Remove outdated TODO comment in messages.dart (flutter/packages#11236) 2026-03-17 [email protected] [web_benchmark] Fix tab connection for newer versions of Chrome (flutter/packages#11266) 2026-03-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 14 directories with 1 update (flutter/packages#11250) 2026-03-17 [email protected] [ci] Enable SwiftPM by default for platform tests (flutter/packages#11271) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Rather than continue to plumb
--swift-package-managersupport into every command to make CI work on stable, just enable it at the machine level before running platform tests so that they all use Swift Package Manager, makingstableandmasteract the same for these tasks.The build-all tests are not changed, as they continue to be the testbed for ensuring that plugins are usable by clients who are using CocoaPods.
A recipe step runs
flutter config --clear-featuresat the start of any bot's run, so this should not cause cross-task bot contamination.