Skip to content

[video_player] Regenerate iOS example with Swift#11275

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
stuartmorgan-g:swift-example-video-player
Mar 17, 2026
Merged

[video_player] Regenerate iOS example with Swift#11275
auto-submit[bot] merged 3 commits intoflutter:mainfrom
stuartmorgan-g:swift-example-video-player

Conversation

@stuartmorgan-g
Copy link
Collaborator

Updates the iOS example app for video_player_avfoundation to a Swift app. Rather than edit in place, this replaces the example app with a fresh copy to minimize drift from current template:

  • The existing ios/ directory was deleted
  • A new copy was created with flutter create --platforms=ios --org=dev.flutter .
  • The RunnerUITest target was re-added
  • The shared RunnerTest was adde, and the placeholder files removed
  • The RunnerUITest code was restored unchanged

This is part of an overall modernization of the example apps; most packages have already been converted to Swift examples.

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@stuartmorgan-g stuartmorgan-g added override: no changelog needed Override the check requiring CHANGELOG updates for most changes CICD Run CI/CD labels Mar 17, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modernizes the iOS example for video_player_avfoundation by replacing the Objective-C project with a new one generated in Swift. The changes update the project to use a scene-based lifecycle and Swift, which aligns with current iOS development practices. The majority of changes are within Xcode project configuration files. The review identified a minor inconsistency in the bundle identifier for the UI test target within the project settings.

@stuartmorgan-g stuartmorgan-g changed the title [video_player] Regenerated iOS example with Swift [video_player] Regenerate iOS example with Swift Mar 17, 2026
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2026
@auto-submit auto-submit bot merged commit 90a2dc1 into flutter:main Mar 17, 2026
81 checks passed
@stuartmorgan-g stuartmorgan-g deleted the swift-example-video-player branch March 18, 2026 13:07
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 18, 2026
flutter/packages@a9d36fb...afa1a1c

2026-03-18 [email protected] Roll Flutter from
732e05d to d117642 (47 revisions) (flutter/packages#11276)
2026-03-18 [email protected] [google_maps_flutter] Add color
scheme support to platform interface (flutter/packages#11278)
2026-03-17 [email protected] [video_player] Regenerate iOS example
with Swift (flutter/packages#11275)
2026-03-17 [email protected] [camera_avfoundation] Remove
outdated TODO comment in messages.dart (flutter/packages#11236)
2026-03-17 [email protected] [web_benchmark] Fix tab connection for
newer versions of Chrome (flutter/packages#11266)
2026-03-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 14 directories
with 1 update (flutter/packages#11250)
2026-03-17 [email protected] [ci] Enable SwiftPM by default for
platform tests (flutter/packages#11271)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: video_player platform-ios platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants