Skip to content

[google_maps_flutter] Add color scheme support to platform interface#11278

Closed
stuartmorgan-g wants to merge 29 commits intoflutter:mainfrom
stuartmorgan-g:maps-web-color-scheme-platform-interface
Closed

[google_maps_flutter] Add color scheme support to platform interface#11278
stuartmorgan-g wants to merge 29 commits intoflutter:mainfrom
stuartmorgan-g:maps-web-color-scheme-platform-interface

Conversation

@stuartmorgan-g
Copy link
Collaborator

Platform interface portion of #10471

Part of flutter/flutter#176445

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

martyfuhry and others added 28 commits November 19, 2025 09:31
…map initialization. Adds comments to MapColorScheme enum.
@stuartmorgan-g stuartmorgan-g requested a review from mdebbar March 18, 2026 13:26
@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Mar 18, 2026
@stuartmorgan-g
Copy link
Collaborator Author

@mdebbar Since #10471 was almost ready to land, I'm breaking out the sub-PRs and doing the minor updates and cleanup from reviews and merges, so that we don't lose the PR.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for colorScheme in the google_maps_flutter_platform_interface. A new MapColorScheme enum is added, and the MapConfiguration class is updated to include the colorScheme property. This includes changes to the constructor, diffing logic, equality checks, and hash code calculation. Corresponding tests have been added to verify the new functionality. The package version is updated to 2.15.0 with a relevant changelog entry.

Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Mar 18, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 18, 2026

auto label is removed for flutter/packages/11278, Failed to merge flutter/packages/11278 with Pull request flutter/packages/11278 could not be merged: Merge already in progress.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2026
@stuartmorgan-g
Copy link
Collaborator Author

Looks like there was some kind of GH API/hook hiccup here; this did get merged.

@stuartmorgan-g
Copy link
Collaborator Author

This is weird, the commit never had any GitHub actions scheduled either so nothing is running post-submit. Since presubmit passed, and this is a low-risk change, I'm going to release it manually rather than revert and reland (which is the only way I know of to re-trigger postsubmit events).

reidbaker pushed a commit to ReportAll/flutter-packages that referenced this pull request Mar 18, 2026
…lutter#11278)

Platform interface portion of flutter#10471

Part of flutter/flutter#176445

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 18, 2026
flutter/packages@a9d36fb...afa1a1c

2026-03-18 [email protected] Roll Flutter from
732e05d to d117642 (47 revisions) (flutter/packages#11276)
2026-03-18 [email protected] [google_maps_flutter] Add color
scheme support to platform interface (flutter/packages#11278)
2026-03-17 [email protected] [video_player] Regenerate iOS example
with Swift (flutter/packages#11275)
2026-03-17 [email protected] [camera_avfoundation] Remove
outdated TODO comment in messages.dart (flutter/packages#11236)
2026-03-17 [email protected] [web_benchmark] Fix tab connection for
newer versions of Chrome (flutter/packages#11266)
2026-03-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 14 directories
with 1 update (flutter/packages#11250)
2026-03-17 [email protected] [ci] Enable SwiftPM by default for
platform tests (flutter/packages#11271)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants