Merged
Conversation
johnpryan
force-pushed
the
refactor-routerdelegate-2
branch
2 times, most recently
from
f5b85e3 to
56056d8
Compare
Contributor
Author
|
@stuartmorgan this change requires Flutter 3.0, which means that these CI steps are failing: Does this CI step need to pass before we land this change? |
Collaborator
Every CI step needs to land before landing a change. Per https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#when-to-update-the-required-version (second bullet point) all you need to do is express the correct Flutter constraint to avoid those steps failing. (Currently the tooling only looks at Flutter constraints, not Dart constraints; it's something we should fix at some point, but in this case the package already requires Flutter so a Flutter constraint shouldn't have any downsides.) |
loic-sharma
reviewed
Jun 9, 2022
loic-sharma
reviewed
Jun 9, 2022
loic-sharma
reviewed
Jun 9, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
loic-sharma
reviewed
Jun 10, 2022
…search doesn't find any
bump go_router_builder to 1.0.5
Analyzing go_router...
error - lib/src/go_route_information_provider.dart:24:41 - A value of type 'WidgetsBinding?' can't be returned from the function '_binding' because it has a return type of 'WidgetsBinding'. - return_of_invalid_type
error - lib/src/go_router.dart:51:33 - The property 'platformDispatcher' can't be unconditionally accessed because the receiver can be 'null'. Try making the access conditional (using '?.') or adding a null check to the target ('!'). - unchecked_use_of_nullable_value
2 issues found.
Co-authored-by: Loïc Sharma <[email protected]>
Co-authored-by: Loïc Sharma <[email protected]>
Co-authored-by: Loïc Sharma <[email protected]>
Co-authored-by: Loïc Sharma <[email protected]>
Co-authored-by: Loïc Sharma <[email protected]>
johnpryan
force-pushed
the
refactor-routerdelegate-2
branch
from
3d3d53a to
fb7c15e
Compare
loic-sharma
reviewed
Jun 14, 2022
johnpryan
added a commit
that referenced
this pull request
Jun 24, 2022
* Call log.clearListeners to disable logging * Remove debugLogDiagnostics from GoRouterDelegate fixes #104470 * Add logging test * format * Fix copyright header * Specify types * Use version 4.0.1 Depends on #2189 * disable logging in tests * remove print * Update CHANGELOG.md
rzetzsche
reviewed
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2183 to re-land #1653 with #2177 included