Migrate imitation_game and pigeon to null safety#2526
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Hi @stuartmorgan I took a stab at migrating some more stuff to null safety. I'm not sure what is causing the Android test failure; I didn't change any of that? As for the publishing error, should I rev the versions given this is only some test stuff? |
|
There's not much information in that failure log; I'm re-running it to see if it's flake. No need for version changes here, the heuristics just don't know about these non-standard test structures. |
Migrate the rest of
imitation_gameandpigeonto full null safety.Contributes to flutter/flutter#110024