Skip to content

[go_router_builder] Bumps go_router version in example folder to v5.0.0#2627

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
chunhtai:bump-go-builder
Sep 21, 2022
Merged

[go_router_builder] Bumps go_router version in example folder to v5.0.0#2627
auto-submit[bot] merged 2 commits intoflutter:mainfrom
chunhtai:bump-go-builder

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Sep 20, 2022

Bumps the example version to unblock ci

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested a review from johnpryan September 20, 2022 21:32
@chunhtai chunhtai marked this pull request as ready for review September 20, 2022 21:32
@chunhtai chunhtai mentioned this pull request Sep 20, 2022
Merged
11 tasks
johnpryan
johnpryan reviewed Sep 20, 2022
View reviewed changes
packages/go_router_builder/CHANGELOG.md Outdated
Copy link
Contributor

@johnpryan johnpryan Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like CI doesn't like this... can we bypass it somehow?

@chunhtai chunhtai added override: no versioning needed Override the check requiring version bumps for most changes autosubmit Merge PR when tree becomes green via auto submit App labels Sep 20, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 20, 2022

auto label is removed for flutter/packages, pr: 2627, due to - The status or check suite legacy-version-analyze CHANNEL:3.0.5 DART_VERSION:2.17.6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2022
@chunhtai chunhtai added autosubmit Merge PR when tree becomes green via auto submit App and removed override: no versioning needed Override the check requiring version bumps for most changes labels Sep 21, 2022
@auto-submit auto-submit bot merged commit 09ef561 into flutter:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryan johnpryan johnpryan approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chunhtai @loic-sharma @johnpryan