[flutter_migrate] base boilerplate files#2694
Merged
auto-submit[bot] merged 9 commits intoflutter:mainfrom Oct 10, 2022
Merged
Conversation
stuartmorgan-g
approved these changes
Oct 10, 2022
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
A couple of nits, but otherwise RSLGTM
script/configs/custom_analysis.yaml
Outdated
| - web_benchmarks/testing/test_app | ||
| # Adopts some flutter_tools rules regarding public api docs due to being an | ||
| # extension of the tool and using tools base code. | ||
| - flutter_migrate No newline at end of file |
Collaborator
There was a problem hiding this comment.
Nit: let's keep this file alphabetized rather than last-added, for simplicity of finding things in it.
|
|
||
| @override | ||
| String toString() => | ||
| 'Exception: $message'; // TODO(ianh): Really this should say "Error". |
Collaborator
There was a problem hiding this comment.
Do you want to just change this rather than replicating the TODO?
Contributor
Author
There was a problem hiding this comment.
Yeah, i'll just change it!
GaryQian
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files are largely replicated from the flutter_tools repo with extraneous features selectively stripped out.
Tests are also from flutter_tools.
Although about half of the lib/src/base code is stripped already, it is likely possible to strip out more of the code in these files, though at some point it makes sense to continue with the landing process instead of chasing a minimal set of boilerplate code.