[pigeon] revert 3b5ae0070738103a80bb9ac12440dd69d598ad2c#2987
[pigeon] revert 3b5ae0070738103a80bb9ac12440dd69d598ad2c#2987auto-submit[bot] merged 8 commits intoflutter:mainfrom
Conversation
…tter#2985)" This reverts commit 3b5ae00.
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
I'm fine keeping this in if you want, we can just land another PR that does the refactor I mentioned in another PR. I can do that possibly tomorrow if you want. Or if you are interested, just let me know. In reality probably no one will add another language anytime soon or fiddle with the code that sets up the generators.
tarrinneal
added
the
autosubmit
tarrinneal
removed
the
autosubmit
@gaaclarke I'm going to restructure things and send up a new pr tomorrow that isn't as reorganizational |
| @@ -1,7 +1,3 @@ | |||
| ## 4.2.15 | |||
There was a problem hiding this comment.
In the future please don't land straight reverts of package updates that have been published, as it creates issues for the next version bump. This should have been 4.2.16 instead.
I've retracted 4.2.15 so we don't have a version in the wild that we no longer have source for, but please do a new PR that restores this changelog entry, with a note saying it was retracted, and restores 4.2.15 as the version, so that the next PR will, correctly, change it to 4.2.16.
There was a problem hiding this comment.
I filed flutter/flutter#117458 because this should be enforced by CI, rather than relying on everyone contributing to flutter/packages and flutter/plugins somehow knowing this.
There was a problem hiding this comment.
Got it, sorry about that.
3 participants
reverts 3b5ae00