Skip to content

[go_router] CustomTransitionPage: Make barrierDismissible work#3026

Merged
auto-submit[bot] merged 7 commits intoflutter:mainfrom
heeyunlee:heeyunlee/barrier-dismissible
Feb 2, 2023
Merged

[go_router] CustomTransitionPage: Make barrierDismissible work#3026
auto-submit[bot] merged 7 commits intoflutter:mainfrom
heeyunlee:heeyunlee/barrier-dismissible

Conversation

@heeyunlee
Copy link
Contributor

@heeyunlee heeyunlee commented Jan 6, 2023 •
edited
Loading

My first PR on the flutter projects. As you mentioned in the below issue, it just required an addition of a few lines, but I added some tests and examples. Please let me know if there are any changes required!

Fixes flutter/flutter#102289

Screen.Recording.2023-01-05.at.7.51.21.PM.mov

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@heeyunlee heeyunlee requested a review from chunhtai as a code owner January 6, 2023 02:41
chunhtai
chunhtai approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai requested a review from hannah-hyj January 6, 2023 19:45
@chunhtai
Copy link
Contributor

chunhtai commented Jan 6, 2023

cc @Hangyujin for secondary review

@heeyunlee heeyunlee mentioned this pull request Jan 10, 2023
Closed
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Jan 24, 2023

@Hangyujin From triage: ping on the secondary review here.

hannah-hyj
hannah-hyj approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2023
@auto-submit auto-submit bot merged commit 44af07b into flutter:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[go_router] CustomTransitionPage.barrierDismissible is not working

4 participants

@heeyunlee @chunhtai @stuartmorgan-g @hannah-hyj