Skip to content

[pigeon] Fix C++ config handling#3094

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
stuartmorgan-g:pigeon-cpp-config
Jan 27, 2023
Merged

[pigeon] Fix C++ config handling#3094
auto-submit[bot] merged 3 commits intoflutter:mainfrom
stuartmorgan-g:pigeon-cpp-config

Conversation

@stuartmorgan-g
Copy link
Collaborator

Removes experimental_ from the serialized names of the C++ pigeon configuration options, so that setting them in a @ConfigurePigeon annotation works. This matches the other experimental generators, where the command line flag has the marking, but not the options structure.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants