Skip to content

[flutter_template_images] Rename list_detail_app to skeleton#310

Closed
brianegan wants to merge 2 commits intoflutter:masterfrom
brianegan:skeleton-images
Closed

[flutter_template_images] Rename list_detail_app to skeleton#310
brianegan wants to merge 2 commits intoflutter:masterfrom
brianegan:skeleton-images

Conversation

@brianegan
Copy link
Contributor

@brianegan brianegan commented Mar 12, 2021 •
edited
Loading

I'm very sorry -- I'm working on a new template for the Flutter team. I thought I'd gotten a final LGTM and asked the team to deploy a version of the flutter_template_images repository using the list_detail_app naming, but a name change was requested afterwards!

The team would like to rename the list_detal_app to skeleton.

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@brianegan brianegan mentioned this pull request Mar 12, 2021
Closed
8 tasks
@filiph filiph requested a review from stuartmorgan-g March 12, 2021 16:36
@goderbauer
Copy link
Member

goderbauer commented Mar 12, 2021

Looks like the naming discussion is still in full swing over at flutter/flutter#76519. It's probably a good idea to wait until that's resolved before proceeding with this one.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft March 24, 2021 15:23
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Mar 24, 2021

Marking as a draft; please remove the draft marker once there's a decision on the other PR.

@brianegan
Copy link
Contributor Author

brianegan commented Mar 25, 2021 •
edited
Loading

I'll go ahead and close this one out for now since I'm unsure on the status of the main PR and unfortunately have no additional time to support them.

Please feel free to reopen!

@brianegan brianegan closed this Mar 25, 2021
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Mar 25, 2021

Closing these two PRs leaves this package in a state where it is not compatible with any version of Flutter. If you are not moving forward with the new template, please revert your earlier change so this package isn't in limbo.

@brianegan
Copy link
Contributor Author

brianegan commented Mar 25, 2021 •
edited
Loading

Thanks @stuartmorgan -- I'd imagine the team will move forward with the template, but my time on the project has drawn to a close. I'll let them take it from here, including reopening this PR if "skeleton" is the name folks want to go with or another PR if another name is selected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianegan @goderbauer @stuartmorgan-g