Skip to content

[pigeon] Standardize host api error handling#3234

Merged
auto-submit[bot] merged 36 commits intoflutter:mainfrom
xegrox:main
Mar 16, 2023
Merged

[pigeon] Standardize host api error handling#3234
auto-submit[bot] merged 36 commits intoflutter:mainfrom
xegrox:main

Conversation

@xegrox
Copy link
Contributor

@xegrox xegrox commented Feb 21, 2023

  • [java] Adds a GeneratedApi.FlutterError exception for passing custom error parameters (code, message, details).
  • [kotlin] Adds a FlutterError exception for passing custom error parameters (code, message, details).
  • [kotlin] Adds a errorClassName option in KotlinOptions for custom error class names.
  • [java] Removes legacy try catch in async apis.
  • Adds FlutterError handling integration tests for all platforms.

Fixes flutter/flutter#120861

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pigeon] Allow full control of PlatformException construction in all languages

5 participants