Skip to content

[in_app_purchase] Prepare for NULLABLE_ARGUMENT_TO_NON_NULL_TYPE#3275

Merged
auto-submit[bot] merged 7 commits intoflutter:mainfrom
asashour:121318_nullable_diagnostic
Apr 11, 2023
Merged

[in_app_purchase] Prepare for NULLABLE_ARGUMENT_TO_NON_NULL_TYPE#3275
auto-submit[bot] merged 7 commits intoflutter:mainfrom
asashour:121318_nullable_diagnostic

Conversation

@asashour
Copy link
Contributor

@asashour asashour commented Feb 23, 2023 •
edited
Loading

flutter/flutter#121318

This PR modifies the code in order not to trigger the incoming diagnostic.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@asashour asashour requested a review from cyanglaz as a code owner February 23, 2023 10:17
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 23, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@asashour asashour mentioned this pull request Feb 23, 2023
Open
3 tasks
@asashour
Copy link
Contributor Author

asashour commented Feb 23, 2023

The false positive linter error is fixed in Dart 3.0.0-264.0.dev, so I think this PR needs to wait a little.

@Hixie
Copy link
Contributor

Hixie commented Feb 23, 2023

test-exempt: fixing lint

This is going to be tricky to land though because it has to be lint-free on both the main branch and the last stable. Search for _ambiguate for ways we've handled that before.

stuartmorgan-g
stuartmorgan-g approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment wording

asashour added 3 commits March 9, 2023 21:33
@asashour
better TODO
61eaee8
@asashour
Merge remote-tracking branch 'up/main' into 121318_nullable_diagnostic
ca6714c 
# Conflicts:
#	packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md
@asashour
Update version.
8831894
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Mar 28, 2023

@bparrishMines or @tarrinneal could you do the second review here?

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot merged commit 02ffd94 into flutter:main Apr 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2023
@engine-flutter-autoroll
02ffd94 [in_app_purchase] Prepare for `NULLABLE_ARGUMENT_TO_NON_NULL_…
0c080f1 
…TYPE` (flutter/packages#3275)
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@asashour @nploi
[in_app_purchase] Prepare for NULLABLE_ARGUMENT_TO_NON_NULL_TYPE (f…
8279b4b 
…lutter#3275)

[in_app_purchase] Prepare for `NULLABLE_ARGUMENT_TO_NON_NULL_TYPE`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests p: in_app_purchase platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asashour @Hixie @stuartmorgan-g @tarrinneal