[ci] Fix some web-platform_tests.#3285
Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom Feb 25, 2023
Merged
Conversation
5b8dae1 to
4d78fd8
Compare
stuartmorgan-g
approved these changes
Feb 25, 2023
Collaborator
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning this up!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2023
10 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[ci] Fix some web-platform_tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does three things:
url_launcher_webtesting inweb-platform_testsin the stable channel.url_launcher_webby adding an "await" on the tester in between tests (this is odd, and only required instablewith Chrome 98, so there might be some weird interaction with that combination)Fixes flutter/flutter#121161
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.