[flutter_adaptive_scaffold] : 🐛 [FIX] : Issue: 121392.#3297
[flutter_adaptive_scaffold] : 🐛 [FIX] : Issue: 121392.#3297auto-submit[bot] merged 39 commits intoflutter:mainfrom
Conversation
- CHANGELOG.md updated. - Version updated to 0.1.1. - ✅ : Test case updated as per changes in /example.
| @@ -1,9 +1,13 @@ | |||
| ## 0.1.1 | |||
|
|
|||
| * 🐛 : FIX - Navigation Rail items not considering `NavigationRailTheme` values - [121135](https://github.com/flutter/flutter/issues/121135) | |||
There was a problem hiding this comment.
Can you remove the emoji here to format it as the others?
| * 🐛 : FIX - Navigation Rail items not considering `NavigationRailTheme` values - [121135](https://github.com/flutter/flutter/issues/121135) | |
| * Fixes `NavigationRail` items not considering `NavigationRailTheme` values - [flutter/flutter#121135](https://github.com/flutter/flutter/issues/121135) |
Also, see the style guide for this: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
| ## 0.1.1 | ||
|
|
||
| * 🐛 : FIX - Navigation Rail items not considering `NavigationRailTheme` values - [121135](https://github.com/flutter/flutter/issues/121135) | ||
| * When `NavigationRailTheme` is provided, it shall that consider that if user has not given theme related data explicitly. |
There was a problem hiding this comment.
| * When `NavigationRailTheme` is provided, it shall that consider that if user has not given theme related data explicitly. | |
| * When `NavigationRailTheme` is provided, it will use the theme for values that the user has not given explicit theme-related values for. |
There was a problem hiding this comment.
change log updated .
| padding: const EdgeInsets.all(8.0), | ||
| child: Container( | ||
| color: const Color.fromARGB(255, 255, 201, 197), | ||
| color: Colors.grey, |
There was a problem hiding this comment.
Why this color change?
| TextStyle? unSelectedLabelTextStyle, | ||
| NavigationRailLabelType labelType = NavigationRailLabelType.none, | ||
| }) { | ||
| final NavigationRailThemeData navRailTheme = |
There was a problem hiding this comment.
Why can't this logic be inside of the returned builder? It's odd to pass a context to this function, and if the logic can be in the returned builder, that makes more sense, since the inherited widget for the theme is then going to rebuild that context based on theme changes, not the context that was passed in.
There was a problem hiding this comment.
Moved logic to returned builder as suggested.
| return Builder( | ||
| builder: (_) { | ||
| return BottomNavigationBar( | ||
| type: BottomNavigationBarType.fixed, |
There was a problem hiding this comment.
Will this remove the animation of the bar?
There was a problem hiding this comment.
Type shall be considered from theme.
# Conflicts: # packages/flutter_adaptive_scaffold/CHANGELOG.md
There was a problem hiding this comment.
The changes in this file need to have unit tests written for them so that they don't regress later.
There was a problem hiding this comment.
The changes in this file also need a test added in adaptive_layout_demo_test.dart.
# Conflicts: # packages/flutter_adaptive_scaffold/CHANGELOG.md # packages/flutter_adaptive_scaffold/README.md # packages/flutter_adaptive_scaffold/example/lib/adaptive_layout_demo.dart # packages/flutter_adaptive_scaffold/example/lib/adaptive_scaffold_demo.dart # packages/flutter_adaptive_scaffold/example/test/adaptive_layout_demo_test.dart
|
@gspencergoog : PR has been updated as per suggested changes and test cases. |
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Thanks so much for the PR!
gspencergoog
added
the
autosubmit
[flutter_adaptive_scaffold] : � [FIX] : Issue: 121392.
3 participants
Changes included in PR are listed as follows.
List which issues are fixed by this PR. You must list at least one issue.
Screenshot evidence PRIOR fix:
Screenshot evidence POST fix:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.