Skip to content

[in_app_purchase_android] Implement BillingClient connection management and introduce BillingClientManager#3303

Merged
auto-submit[bot] merged 11 commits intoflutter:mainfrom
Utopia-USS:fix_in_app_purchase_android_billing_client_reconnect
Apr 10, 2023
Merged

[in_app_purchase_android] Implement BillingClient connection management and introduce BillingClientManager#3303
auto-submit[bot] merged 11 commits intoflutter:mainfrom
Utopia-USS:fix_in_app_purchase_android_billing_client_reconnect

Conversation

@SynSzakala
Copy link
Contributor

@SynSzakala SynSzakala commented Feb 26, 2023

This PR adds management of BillingClient connection to Android implementation of InAppPurchase. This should fix issues caused by lost connections.

New and previously existing connection management is extracted to a new component, BillingClientManager.
This component is exported in billing_client_wrappers.dart, so that it can also be used when interacting with BillingClient directly.

Fixes flutter/flutter#110663

Migrated from flutter/plugins PR #6309

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[in_app_purchase][android] BillingClient connection is not restored after it's lost

3 participants