[webview_flutter_android] Adds a WebViewFlutterApi#3324
[webview_flutter_android] Adds a WebViewFlutterApi#3324auto-submit[bot] merged 9 commits intoflutter:mainfrom
Conversation
bparrishMines
changed the title
| public void setUp() { | ||
| instanceManager = InstanceManager.open(identifier -> {}); | ||
|
|
||
| instanceManager.addDartCreatedInstance(mockWebView, 0L); |
There was a problem hiding this comment.
Removed so that it is tested that it can handle adding the mockWebView.
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM! One optional change.
| if (webViewIdentifier == null) { | ||
| throw new IllegalStateException("Could not find identifier for WebView."); | ||
| } | ||
| final WebViewFlutterApiImpl webViewFlutterApi = |
There was a problem hiding this comment.
Optional: Should we just make a private field with this API on object construction, so we don't need the boilerplate of creating one in every single callback? I know it's cheap to create, but it should also be very cheap to just keep it around.
bparrishMines
added
the
autosubmit
|
It is available as a new version on pub.dev? |
|
@GeylanKalafMohe Yes. In the future, you can just check pub.dev to see what has been published. |
But why is it not published on webview_flutter in a new version?? |
|
@stuartmorgan I know it is endorsed but how does my pubspec.yaml file and the webview_flutter know that there is a new version of an endorsed package in webview_flutter? How can it benefit from it? |
Because there are no changes to
The same way you would get updates to any other packages you have transitive dependencies on: |
|
This issue still happens with the latest version.
|
[webview_flutter_android] Adds a WebViewFlutterApi
3 participants
This should fix flutter/flutter#119899
It's possible that a
WebViewreturned in aWebViewClientcallback could be one that was not created by Dart. I'm unable to find a reproducible situation, but it's definitely possible that this is the cause of the problem.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.