[shared_preferences] Changes test class to extend platform rather than implement.#3502
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Mar 21, 2023
Merged
[shared_preferences] Changes test class to extend platform rather than implement.#3502auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
stuartmorgan-g
approved these changes
Mar 20, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM (with cleanup nit).
Per offline discussion, extends for a fake doesn't really have the usual concerns about accidental real behaviors since the base class should always be a bunch of unimplementeds, so making it less fragile is the better option here.
packages/shared_preferences/shared_preferences/test/shared_preferences_test.dart
Show resolved
Hide resolved
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 21, 2023
…ther than implement. (flutter/packages#3502)
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…n implement. (flutter#3502) [shared_preferences] Changes test class to extend platform rather than implement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix unblocks #3497
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.