Skip to content

Migrate to .ci.yaml#361

Merged
CaseyHillers merged 2 commits intoflutter:masterfrom
CaseyHillers:star-migration
May 21, 2021
Merged

Migrate to .ci.yaml#361
CaseyHillers merged 2 commits intoflutter:masterfrom
CaseyHillers:star-migration

Conversation

@CaseyHillers
Copy link
Contributor

Issues

flutter/flutter#82303

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite build-ipas has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite local_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocked on having pre-submit config validation

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers merged commit e72d7b3 into flutter:master May 21, 2021
@CaseyHillers CaseyHillers deleted the star-migration branch May 21, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants