[pigeon] Fix Obj-C signature mismatch#3657
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Apr 7, 2023
Merged
Conversation
Updates the definition of the `*GetCodec` function to have a `void` parameter list, matching its declaration, to fix a new warning in clang 15. Fixes flutter/flutter#124343
github-actions
bot
added
p: pigeon
platform-android
platform-ios
platform-macos
platform-windows
labels
tarrinneal
approved these changes
Apr 6, 2023
stuartmorgan-g
added
the
autosubmit
Collaborator
Author
|
I can do Obj-C Pigeon updates in flutter/packages tomorrow to make sure we won't be broken by future Xcode updates in that repo. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 7, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[pigeon] Fix Obj-C signature mismatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the definition of the
*GetCodecfunction to have avoidparameter list, matching its declaration, to fix a new warning in clang 15.Fixes flutter/flutter#124343
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).