[various] Add targetCompatibility to build.gradle#3825
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Apr 26, 2023
Merged
[various] Add targetCompatibility to build.gradle#3825auto-submit[bot] merged 3 commits intoflutter:mainfrom
targetCompatibility to build.gradle#3825auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While current docs about
targetCompatibilitysay that it defaults tosourceCompatibility, for older toolchains (AGP?) that is apparently not the case, and it's a build error to setsourceCompatibilitywithouttargetCompatibility.This adds enforcement that it's set to
gradle-check, and fixes all of the violations.Fixes flutter/flutter#125482
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).