Skip to content

[various] Add targetCompatibility to build.gradle#3825

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
stuartmorgan-g:tool-android-target-compat
Apr 26, 2023
Merged

[various] Add targetCompatibility to build.gradle#3825
auto-submit[bot] merged 3 commits intoflutter:mainfrom
stuartmorgan-g:tool-android-target-compat

Conversation

@stuartmorgan-g
Copy link
Collaborator

While current docs about targetCompatibility say that it defaults to sourceCompatibility, for older toolchains (AGP?) that is apparently not the case, and it's a build error to set sourceCompatibility without targetCompatibility.

This adds enforcement that it's set to gradle-check, and fixes all of the violations.

Fixes flutter/flutter#125482

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[google_sign_in]: source release 1.8 requires target release 1.8 error with older AGP/Gradle versions

2 participants