[local_auth] Fix cancel handling on Android#4120
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom May 30, 2023
Merged
[local_auth] Fix cancel handling on Android#4120auto-submit[bot] merged 3 commits intoflutter:mainfrom
auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
Fixes a regression introduced during the Pigeon conversion where a canceled auth returned success instead of failure. Adds initial unit test coverage of `AuthenticationHelper`, which was previously untested, including coverage of the incorrect code path. Fixes flutter/flutter#127732
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2023
flutter/packages@4a5cc3e...c85111c 2023-05-30 [email protected] [local_auth] Fix cancel handling on Android (flutter/packages#4120) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced during the Pigeon conversion where a canceled auth returned success instead of failure.
Adds initial unit test coverage of
AuthenticationHelper, which was previously untested, including coverage of the incorrect code path.Fixes flutter/flutter#127732
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).