remove unnecessary typed_data imports#4136
Merged
auto-submit[bot] merged 10 commits intoflutter:mainfrom Jun 6, 2023
Merged
Conversation
dimabran
requested review from
bparrishMines,
camsim99,
cyanglaz,
ditman,
gspencergoog,
hellohuanlin,
reidbaker,
stuartmorgan-g and
tarrinneal
as code owners
dimabran
force-pushed
the
remove_unnecessary_imports
branch
2 times, most recently
from
ba4ca4f to
98b6ba5
Compare
dimabran
force-pushed
the
remove_unnecessary_imports
branch
from
98b6ba5 to
d8a6728
Compare
stuartmorgan-g
requested changes
Jun 5, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
tarrinneal
approved these changes
Jun 5, 2023
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
lgtm once @stuartmorgan's requests are addressed.
This reverts commit b182eb1.
This reverts commit ecc267e.
stuartmorgan-g
added
override: no versioning needed
Collaborator
|
Overriding version and changelog checks; |
Collaborator
|
For some reason the Cirrus checks didn't start for the last commit, but since everything but the version check was green in the previous commit, and the last commit only reverted the submodule, it's fine to land. |
Collaborator
|
Hm, @tarrinneal could you re-approve? Your approval was cleared somehow. |
tarrinneal
approved these changes
Jun 6, 2023
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2023
flutter/packages@db4e5c2...da72219 2023-06-06 [email protected] remove unnecessary typed_data imports (flutter/packages#4136) 2023-06-06 [email protected] [local_auth_android] Bump androidx.fragment to 1.5.7 and androidx.core to 1.10.1 (flutter/packages#4142) 2023-06-05 [email protected] [google_maps] Endorses package:google_maps_flutter_web. (flutter/packages#4124) 2023-06-05 [email protected] [ci] Removes bespoke web scripts. (flutter/packages#4129) 2023-06-05 [email protected] [webview_flutter]: fix typo (flutter/packages#4070) 2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 31.1-android to 32.0.0-android in /packages/camera/camera_android_camerax/android (flutter/packages#4116) 2023-06-05 [email protected] [tools] Fix OOB test error (flutter/packages#4144) 2023-06-05 [email protected] [path_provider] Allow win32 up to version 5.x (flutter/packages#4125) 2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 31.1-android to 32.0.0-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4112) 2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 2.18.6 to 2.18.7 in /packages/video_player/video_player_android/android (flutter/packages#4053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all the unnecessary commented out typed_data import ignore
Fixes Issue #128140
Pre-launch Checklist
dart format.)pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.