Skip to content

[all] Update UIViewControllerBasedStatusBarAppearance to true#4225

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
cyanglaz:status_bar_appearance_true
Jun 19, 2023
Merged

[all] Update UIViewControllerBasedStatusBarAppearance to true#4225
auto-submit[bot] merged 2 commits intoflutter:mainfrom
cyanglaz:status_bar_appearance_true

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Jun 15, 2023

Now that we support UIViewControllerBasedStatusBar by default (after engine roll: flutter/flutter@c716776), we should make this value to be true.

Part of flutter/flutter#128969

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: animations p: camera p: dynamic_layouts The dynamic_layouts package p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_adaptive_scaffold p: flutter_markdown p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: ios_platform_images p: local_auth p: palette_generator p: path_provider p: pigeon p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyanglaz @hellohuanlin @stuartmorgan-g