[flutter_image] added example app#4353
Conversation
f15a546 to
598dd5f
Compare
|
@Nitin-Poojary thanks for the contribution! However the branch on this PR has gotten a little bit messed up; it touches way more files than it should and includes commits not made by you (this is normally the sign of a bad rebase/update). I'm going to mark this PR as a draft until the branch gets fixed, it cannot land in its current state. |
515d6e9 to
2c1987b
Compare
|
Thank you for pointing out the issues. I apologize for any inconvenience caused. I have now fixed the problems. I believe it is now appropriate to mark this pull request as ready for review again. |
|
Could you please look into the failing tests? |
|
Finally, I really appreciate how much you assisted me during this whole process. Thank you! |
|
Should I push more commits regarding TODO from this branch? |
|
A follow-up would need to be a new PR in a new branch against the latest |
|
Okay. |
|
Since the example app hasn't appeared in the pinned version, should I wait for it to be included before proceeding? |
|
I'm not sure what pinned version you are referring to; if you pull from |
Could you please provide more details or clarification on this? |
|
Sure, what information are you looking for? |
|
Regarding the use of the pinned version, as you suggested to use it instead of the main branch. |
|
Sorry, I'm not sure what your question is. If it's whether this needs to continue to use a pinned version, then yes, that is still true per my previous comments. |
|
So using a pinned version to my asset image link will make it look like |
A pinned version means you use a specific hash rather than something like |
|
Okay, so that means I have to pull changes from main and create a separate hash and address that which will have my example app in it, am I correct? If so how to do it? |
I'm not sure what you mean. Every commit in a git repository has a hash. There are already dozens of hashes that have this example in them. The commit that landed this PR and the latest commit, for example, both have it. |
|
Thank you for your response even on a Sunday. I was unsure about these hashes and how to obtain one, but your explanation that they are hashes of commits has cleared up my doubt. |
Added example app for flutter_image package
closes #128699
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).