[google_maps_flutter_platform_interface] Platform interface changes for #3258#4478
Merged
auto-submit[bot] merged 7 commits intoflutter:mainfrom Jul 17, 2023
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Merged
11 tasks
stuartmorgan-g
requested changes
Jul 15, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
The applyDiff tests look good, thanks! There should be tests for equality (that changing just each of the new properties causes objects not to be equal), hash (that changing just each of the new properties changes the hash) and diffFrom as well though.
...gle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/map_configuration.dart
Show resolved
Hide resolved
...gle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/map_configuration.dart
Outdated
Show resolved
Hide resolved
stuartmorgan-g
approved these changes
Jul 17, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM once the version merge is fixed, thanks!
packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md
Show resolved
Hide resolved
…b-config-options-platform-interface
ditman
approved these changes
Jul 17, 2023
|
|
||
| import 'package:flutter/widgets.dart'; | ||
|
|
||
| import 'ui.dart'; |
Member
There was a problem hiding this comment.
Removing import 'ui.dart'; is great, thanks!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 18, 2023
flutter/packages@6889cca...3e8b813 2023-07-18 [email protected] [video_player] Fix iOS crash with multiple players (flutter/packages#4202) 2023-07-17 [email protected] [pigeon] Enable Android emulator tests in CI (flutter/packages#4484) 2023-07-17 [email protected] [video_player] Add optional web options [Platform interface] (flutter/packages#4433) 2023-07-17 [email protected] [google_maps_flutter_platform_interface] Platform interface changes for #3258 (flutter/packages#4478) 2023-07-17 [email protected] [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826) 2023-07-17 [email protected] [camerax] Add flash configuration for image capture (flutter/packages#3800) 2023-07-17 [email protected] Remove `equatable` and `xml` allowances (flutter/packages#4489) 2023-07-17 [email protected] [ci] Switch Linux platform tests to LUCI (flutter/packages#4479) 2023-07-17 [email protected] [ci] Adjust bot configurations (flutter/packages#4485) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@6889cca...3e8b813 2023-07-18 [email protected] [video_player] Fix iOS crash with multiple players (flutter/packages#4202) 2023-07-17 [email protected] [pigeon] Enable Android emulator tests in CI (flutter/packages#4484) 2023-07-17 [email protected] [video_player] Add optional web options [Platform interface] (flutter/packages#4433) 2023-07-17 [email protected] [google_maps_flutter_platform_interface] Platform interface changes for flutter#3258 (flutter/packages#4478) 2023-07-17 [email protected] [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826) 2023-07-17 [email protected] [camerax] Add flash configuration for image capture (flutter/packages#3800) 2023-07-17 [email protected] Remove `equatable` and `xml` allowances (flutter/packages#4489) 2023-07-17 [email protected] [ci] Switch Linux platform tests to LUCI (flutter/packages#4479) 2023-07-17 [email protected] [ci] Adjust bot configurations (flutter/packages#4485) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3258