[plugin_platform_interface] Adopt code-excerpts#4534
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Jul 20, 2023
Merged
[plugin_platform_interface] Adopt code-excerpts#4534auto-submit[bot] merged 3 commits intoflutter:mainfrom
auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
Updates the README to use code excerpts from the unit test file, adjusting the existing test code slightly to make it suitable for use in the example. Also fleshes out the example a bit more, to make it look more like a real class. Finally, adds a note about `base`, linking to the ongoing discussion, since we don't have a decision yet, but people may well wonder why this class exists given `base`. Part of flutter/flutter#102679
tarrinneal
approved these changes
Jul 20, 2023
|
|
||
| In Dart 3, [the `base` keyword](https://dart.dev/language/class-modifiers#base) | ||
| was introduced to the language, which allows enforcing that implementations | ||
| of an interface use `extends` rather than `implements`. The Flutter team is |
Contributor
There was a problem hiding this comment.
"which allows enforcing that implementations of an interface use"
I'm not sure what this is supposed to say
Collaborator
Author
There was a problem hiding this comment.
I adjusted the wording; hopefully it's clearer now.
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 21, 2023
flutter/packages@674179f...2266a76 2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525) 2023-07-20 [email protected] [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535) 2023-07-20 [email protected] [go_router] fix error handling page link (flutter/packages#4296) 2023-07-20 [email protected] [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534) 2023-07-20 [email protected] [ci] Simplify Dockerfile (flutter/packages#4530) 2023-07-20 [email protected] [ci] Enable Windows Dart unit test sharding (flutter/packages#4528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@674179f...2266a76 2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525) 2023-07-20 [email protected] [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535) 2023-07-20 [email protected] [go_router] fix error handling page link (flutter/packages#4296) 2023-07-20 [email protected] [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534) 2023-07-20 [email protected] [ci] Simplify Dockerfile (flutter/packages#4530) 2023-07-20 [email protected] [ci] Enable Windows Dart unit test sharding (flutter/packages#4528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the README to use code excerpts from the unit test file, adjusting the existing test code slightly to make it suitable for use in the example.
Also fleshes out the example a bit more, to make it look more like a real class.
Finally, adds a note about
base, linking to the ongoing discussion, since we don't have a decision yet, but people may well wonder why this class exists givenbase.Part of flutter/flutter#102679
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).