[flutter_adaptive_scaffold] Fix top padding for NavigationBar#4661
[flutter_adaptive_scaffold] Fix top padding for NavigationBar#4661auto-submit[bot] merged 4 commits intoflutter:mainfrom ctrysbita:main
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@gspencergoog Could you have a review on this? |
|
The library has been broken for 3 month now. Please review this fix |
|
In order to proceed with the review, this PR will need to have some tests to prevent regression in the future, as the message from the bot above describes. It just needs to be a test that fails without your change, and succeeds with your change. |
|
@gspencergoog The tests were already updated. |
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Sorry, I didn't notice that the change included the file in the test directory.
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
LGTM, welcome! Thanks for contributing!
flutter/packages@c730a90...3060b1a 2023-08-23 [email protected] [rfw] Support web (as JS) (flutter/packages#4650) 2023-08-22 [email protected] [webview_flutter] Update sample code. (flutter/packages#4727) 2023-08-22 [email protected] [flutter_adaptive_scaffold] Fix top padding for NavigationBar (flutter/packages#4661) 2023-08-22 [email protected] Remove deprecated `ImageProvider` methods (flutter/packages#4725) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
4 participants
This pr removes the top padding in
MediaQueryfor NavigationBar to fix unexpected padding.The
Scaffoldin flutter framework actually did this but this package didn't.Fix flutter/flutter#127088
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.