Skip to content

[camerax] Implements torch mode#4903

Merged
auto-submit[bot] merged 53 commits intoflutter:mainfrom
camsim99:camx_torch
Oct 10, 2023
Merged

[camerax] Implements torch mode#4903
auto-submit[bot] merged 53 commits intoflutter:mainfrom
camsim99:camx_torch

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Sep 11, 2023 •
edited
Loading

Implements the torch flash mode. Also wraps classes necessary for the implementation (a method in Camera, CameraControl).

Fixes flutter/flutter#120715.
Fixes flutter/flutter#115846.
Part of flutter/flutter#115847.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[camerax] Implement flash mode configuration [camera] Add Camera class to CameraX plugin

3 participants

@camsim99 @bparrishMines @gmackall