Skip to content

[image_picker] Add missing entitlements to macOS example#4931

Merged
stuartmorgan-g merged 1 commit intoflutter:mainfrom
stuartmorgan-g:image-picker-app-facing-macos-example
Sep 15, 2023
Merged

[image_picker] Add missing entitlements to macOS example#4931
stuartmorgan-g merged 1 commit intoflutter:mainfrom
stuartmorgan-g:image-picker-app-facing-macos-example

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Sep 15, 2023

When endorsing macOS and adding the example app, I forgot to add the required entitlement, so the example didn't work.

The actual fix is the entitlements file; the Runner.xc* changes are auto-generated by running flutter build macos; usually we do that before landing examples but clearly I didn't remember to actually run the example when endorsing in this case...

Fixes flutter/flutter#134817

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: image_picker platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[image_picker] Example does not work on macOS

2 participants