[flutter_markdown] Footnote support#5058
Merged
domesticmouse merged 7 commits intoflutter:mainfrom Oct 4, 2023
Merged
Conversation
domesticmouse
approved these changes
Oct 2, 2023
Contributor
domesticmouse
left a comment
domesticmouse
left a comment
There was a problem hiding this comment.
LGTM once the Linux build failure is sorted
Contributor
|
PTAL @tarrinneal |
Contributor
Author
|
Hi, I found the issue during adding it to my application. To support superscript the font which is used has to support
I have prepared demo with basic implementation. In the case of using custom font feature everything is ready. Using Transform.translate is quite buggy because it doesn't support Demo with
|
Contributor
merged mid review, lol. no concerns about the comment from @dawidope ? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 5, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 5, 2023
flutter/packages@d654f75...6714d50 2023-10-04 [email protected] [webview_flutter] Fix XCUITest in Xcode 15 (flutter/packages#5071) 2023-10-04 [email protected] [path_provider] Fix integration tests (flutter/packages#5075) 2023-10-04 [email protected] [flutter_markdown] Footnote support (flutter/packages#5058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@d654f75...6714d50 2023-10-04 [email protected] [webview_flutter] Fix XCUITest in Xcode 15 (flutter/packages#5071) 2023-10-04 [email protected] [path_provider] Fix integration tests (flutter/packages#5075) 2023-10-04 [email protected] [flutter_markdown] Footnote support (flutter/packages#5058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
Fix not solved issue from another PR: #5058 (comment). I chose the 2nd option with custom font feature.
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Fix not solved issue from another PR: flutter#5058 (comment). I chose the 2nd option with custom font feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for footnote which was introduced in
markdown7.1.0 which is used influtter_markdownpackage.It allows to use the newest version of markdown without overriding it to 7.0.0 because of missing
sectiontag handling.Issue: flutter/flutter#127425
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.