camera_android: Camera.java pausePreview null check#5265
Merged
auto-submit[bot] merged 12 commits intoflutter:mainfrom Nov 28, 2023
Merged
camera_android: Camera.java pausePreview null check#5265auto-submit[bot] merged 12 commits intoflutter:mainfrom
auto-submit[bot] merged 12 commits intoflutter:mainfrom
Conversation
Check `captureSession` before call to stopRepeating in pausePreview.
camsim99
approved these changes
Oct 31, 2023
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
LGTM! @stuartmorgan for second review
stuartmorgan-g
requested changes
Nov 2, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
- I added new tests to check the change I am making, or this PR is [test-exempt].
Where is this test?
Contributor
Author
|
@stuartmorgan |
camsim99
requested changes
Nov 22, 2023
packages/camera/camera_android/android/src/test/java/io/flutter/plugins/camera/CameraTest.java
Outdated
Show resolved
Hide resolved
…r/plugins/camera/CameraTest.java Co-authored-by: Camille Simon <[email protected]>
camsim99
approved these changes
Nov 27, 2023
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
LGTM! Over to @stuartmorgan
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 29, 2023
flutter/packages@3c05466...e4aaba8 2023-11-28 [email protected] [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471) 2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483) 2023-11-28 [email protected] [flutter image] Changed image link to use image within package (flutter/packages#5326) 2023-11-28 [email protected] camera_android: Camera.java pausePreview null check (flutter/packages#5265) 2023-11-28 [email protected] [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
flutter/packages@3c05466...e4aaba8 2023-11-28 [email protected] [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471) 2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483) 2023-11-28 [email protected] [flutter image] Changed image link to use image within package (flutter/packages#5326) 2023-11-28 [email protected] camera_android: Camera.java pausePreview null check (flutter/packages#5265) 2023-11-28 [email protected] [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Check
captureSessionbefore call to stopRepeating in pausePreview.[camera_android] sometimes crashes on pausePreview #137544
If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).