[flutter image] Changed image link to use image within package#5326
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
This should have a version change and CHANGELOG entry since it changes the file that's published on the example tab on pub.dev.
There was a problem hiding this comment.
Why is png hard-coded, but the filename not? If the caller can pass an arbitrary asset, there's no guarantee that it would be a png.
There was a problem hiding this comment.
Make sense, I will fix it.
Nitin-Poojary
force-pushed
the
flutter_image/fixing_todo
branch
from
76a4820 to
0784ee4
Compare
|
Why is tree-status failing, is it something related to this pr? |
Because the tree was closed at the time.
No, tree-status is unrelated to PRs. |
|
Okay, Thanks. |
packages/flutter_image/CHANGELOG.md
Outdated
There was a problem hiding this comment.
This is not a new feature; it should be 4.1.11
There was a problem hiding this comment.
Yes I tried that before but the test failed saying Incorrectly updated version. Like it is failing now.
There was a problem hiding this comment.
I missed that you were adding two different versions to the CHANGELOG. Why are you adding both .10 and .11 at the same time? The current version is .9, so the next version should be .10 (as the error message says).
There was a problem hiding this comment.
Yes, that's because before the latest version was marked as NEXT so I changed it to 4.1.10 and marked mine as 4.1.11. So should I add both mine and and previously NEXT as one 4.1.10?
There was a problem hiding this comment.
Nitin-Poojary
force-pushed
the
flutter_image/fixing_todo
branch
from
005254f to
7dd60c7
Compare
|
test-exempt: code refactor with no semantic change |
|
@tarrinneal Could you do the secondary review on this? |
tarrinneal
added
the
autosubmit
flutter/packages@3c05466...e4aaba8 2023-11-28 [email protected] [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471) 2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483) 2023-11-28 [email protected] [flutter image] Changed image link to use image within package (flutter/packages#5326) 2023-11-28 [email protected] camera_android: Camera.java pausePreview null check (flutter/packages#5265) 2023-11-28 [email protected] [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@3c05466...e4aaba8 2023-11-28 [email protected] [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471) 2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483) 2023-11-28 [email protected] [flutter image] Changed image link to use image within package (flutter/packages#5326) 2023-11-28 [email protected] camera_android: Camera.java pausePreview null check (flutter/packages#5265) 2023-11-28 [email protected] [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Changed image link to use image within package.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).