[in_app_purchase] add storefront in skpaymentqueuewrapper#5348
[in_app_purchase] add storefront in skpaymentqueuewrapper#5348auto-submit[bot] merged 5 commits intoflutter:mainfrom
Conversation
update changelog fix test version check
|
|
||
| @property(NS_NONATOMIC_IOSONLY, weak, nullable) id<SKPaymentQueueDelegate> delegate API_AVAILABLE( | ||
| ios(13.0), macos(10.15), watchos(6.2)); | ||
| @property(NS_NONATOMIC_IOSONLY, readonly, nullable) |
There was a problem hiding this comment.
Why would we only want this to be nonatomic on iOS? Surely we don't have different threading semantics for macOS?
There was a problem hiding this comment.
The storefront property in SKPaymentQueue is nonatomic on iOS. I tried to keep it the sam way but yeah we don't need it. Will revert to nonatomic for all.
| } | ||
| result([FIAObjectTranslator getMapFromSKStorefront:storefront]); | ||
| return; | ||
| } else { |
There was a problem hiding this comment.
Nit: no need to wrap code after an early return in else.
| } | ||
|
|
||
| - (void)getStorefront:(FlutterResult)result { | ||
| if (@available(iOS 13.0, *)) { |
There was a problem hiding this comment.
We should include macOS 10.15+ here too.
| result([FIAObjectTranslator getMapFromSKStorefront:storefront]); | ||
| return; | ||
| } else { | ||
| NSLog(@"storefront is not avaialbe in iOS below 13.0."); |
There was a problem hiding this comment.
And this should mention both iOS and macOS.
| } | ||
|
|
||
| - (void)testPaymentQueueStorefront { | ||
| if (@available(iOS 13, *)) { |
...p_purchase/in_app_purchase_storekit/lib/src/store_kit_wrappers/sk_payment_queue_wrapper.dart
Outdated
Show resolved
Hide resolved
|
@stuartmorgan Updated as per your comments. PTAL! |
|
|
||
| - (void)testPaymentQueueStorefront { | ||
| if (@available(iOS 13, macOS 10.15, *)) { | ||
| { |
There was a problem hiding this comment.
Nit: These should be two separate test methods, rather than sub-blocks of the same test. Unit tests should each test as few things as is feasible.
| SKPaymentQueueDelegateWrapper? _paymentQueueDelegate; | ||
| SKTransactionObserverWrapper? _observer; | ||
|
|
||
| /// Calls [`[SKPaymentQueue storefront]`](https://developer.apple.com/documentation/storekit/skpaymentqueue/3182430-storefront?language=objc) |
There was a problem hiding this comment.
This is missing a period.
| SKTransactionObserverWrapper? _observer; | ||
|
|
||
| /// Calls [`[SKPaymentQueue storefront]`](https://developer.apple.com/documentation/storekit/skpaymentqueue/3182430-storefront?language=objc) | ||
| /// Returns `null` if the user's device is below iOS 13.0 or macOS 10.15. |
There was a problem hiding this comment.
And a blank comment line before this one, per Effective Dart.
cyanglaz
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages/5348, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
cyanglaz
added
the
autosubmit
flutter/packages@0cd2378...07b4b29 2023-11-16 [email protected] [script] use dart:io support for forwarding stdout/stderr (flutter/packages#5410) 2023-11-15 [email protected] Manual roll Flutter (stable) from d211f42 to db7ef5b (1539 revisions) (flutter/packages#5409) 2023-11-15 [email protected] [in_app_purchase] add storefront in skpaymentqueuewrapper (flutter/packages#5348) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Add
Future<SKStorefrontWrapper?> storefront()method in SKPaymentQueue wrapperfixes flutter/flutter#137560
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.