[image_picker] Adopt code excerpts in README by mike-v2 · Pull Request #5523 · flutter/packages

mike-v2 · 2023-11-30T01:21:37Z

Improves image_picker_for_web README example and updates it to use code excerpts.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

mike-v2 · 2023-11-30T01:25:39Z

Tweaked the README code a tiny bit to make it more testable.
Added a small image (from flutter_image/example/assets) in order to test creating an Image widget from an XFile's path.

mike-v2 · 2023-11-30T05:45:31Z

await XFile.readAsBytes() seems to be causing an issue on web. It's returning a valid Uint8List but for some reason it causes the test to stall indefinitely once it reaches the next await or the end of the test.

stuartmorgan-g · 2023-12-15T19:44:22Z

packages/image_picker/image_picker_for_web/example/test/readme_excerpts_test.dart

+  testWidgets('getImageFromPath loads image from XFile path',
+      (WidgetTester tester) async {
+    // Create an XFile using the test image path.
+    final XFile pickedFile = XFile('assets/flutter-mark-square-64.png');


IIRC, you can't read asset files in tests on web, and this would need to be a blob instead on web. @ditman Am I remembering that correctly?

Yes, this is correct. Here's a couple of examples of XFiles in tests:

https://github.com/flutter/packages/blob/main/packages/cross_file/test/x_file_html_test.dart

https://github.com/flutter/packages/blob/main/packages/file_selector/file_selector_web/example/integration_test/file_selector_web_test.dart#L134-L137

mike-v2 · 2024-01-09T20:02:41Z

Even after creating a blob instead of loading an asset, I'm still having the same issue as before with XFile.readAsBytes(). I can get the test to pass without errors if I replace
image = Image.memory(await pickedFile.readAsBytes());
with this:
final Uint8List bytes = Uint8List.fromList(<int>[0, 1, 2, 3, 4, 5]);
image = Image.memory(bytes);

I'm wondering if it's related to this issue?
It's also very possible I'm making a dumb mistake!

Increment version number

stuartmorgan-g · 2024-01-30T20:57:56Z

@ditman Any thoughts on how to structure this test?

stuartmorgan-g · 2024-03-05T20:46:11Z

@ditman Ping on the test question above.

ditman · 2024-04-12T20:35:27Z

Looking!

ditman · 2024-04-12T23:52:02Z

I moved the test to integration_test and added the missing IntegrationTestWidgetsFlutterBinding.ensureInitialized()... I also did other changes (to ensure that the PNG image is a valid one), but I'm not sure if those were needed. Now the tests run and pass!

@stuartmorgan if you're happy with the new contents of the README, I think this could land.

script/configs/temp_exclude_excerpt.yaml

stuartmorgan-g

LGTM with one fix.

auto-submit · 2024-04-15T15:25:24Z

auto label is removed for flutter/packages/5523, due to - The status or check suite Linux_android android_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

stuartmorgan-g · 2024-04-15T16:54:05Z

The presubmit failure is OOB breakage I just landed a fix for; once that is published I'll re-run.

auto-submit · 2024-04-15T18:39:27Z

auto label is removed for flutter/packages/5523, due to - The status or check suite Linux_android android_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

…s#5523)

flutter/packages@6698b2d...90c876d 2024-04-16 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.10 to 3.25.0 (flutter/packages#6545) 2024-04-16 [email protected] [CupertinoIcons] fix broken icons and vertical alignment, bump the version to 1.08 (flutter/packages#6520) 2024-04-16 [email protected] [video_player] Calls `onDestroy` instead of `initialize` in onDetachedFromEngine (flutter/packages#6501) 2024-04-15 [email protected] [image_picker] Adopt code excerpts in README (flutter/packages#5523) 2024-04-15 [email protected] [url_launcher][web] Link should work when triggered by keyboard (flutter/packages#6505) 2024-04-15 [email protected] Manual roll Flutter from 53cba24 to 2e748e8 (19 revisions) (flutter/packages#6541) 2024-04-15 [email protected] Update local_auth_android minSdkVersion to 19 (flutter/packages#6537) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Improves image_picker_for_web README example and updates it to use code excerpts. Part of [flutter/flutter#102679](flutter/flutter#102679)

[image_picker] Adopt code excerpts in README

515a3b6

mike-v2 requested a review from ditman as a code owner November 30, 2023 01:21

github-actions bot added p: image_picker platform-web labels Nov 30, 2023

fix test name

4dec5ee

tarrinneal requested review from stuartmorgan-g and tarrinneal December 13, 2023 21:03

stuartmorgan-g reviewed Dec 15, 2023

View reviewed changes

Create blob instead of loading assets on web

da1bafd

Merge branch 'main' into code-excerpts-image-picker

072171f

Increment version number

ditman added 3 commits April 12, 2024 13:49

Merge branch 'main' into code-excerpts-image-picker

5580edf

Move test file to integration_test.

d2b1bcf

Tweak integration test.

bb23141

ditman approved these changes Apr 12, 2024

View reviewed changes

stuartmorgan-g reviewed Apr 15, 2024

View reviewed changes

script/configs/temp_exclude_excerpt.yaml Outdated Show resolved Hide resolved

stuartmorgan-g approved these changes Apr 15, 2024

View reviewed changes

stuartmorgan-g added 2 commits April 15, 2024 10:59

Fix config merge

2c0e85e

Merge branch 'main' into code-excerpts-image-picker

ea940ff

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024

stuartmorgan-g mentioned this pull request Apr 15, 2024

Update local_auth_android minSdkVersion to 19 #6537

Merged

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024

Merge branch 'main' into code-excerpts-image-picker

828893c

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024

auto-submit bot merged commit 9a24904 into flutter:main Apr 15, 2024

engine-flutter-autoroll mentioned this pull request Apr 16, 2024

Roll Packages from 6698b2d67999 to 701d60a08941 (6 revisions) flutter/flutter#146824

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 16, 2024

9a24904 [image_picker] Adopt code excerpts in README (flutter/package…

a1f7666

…s#5523)

engine-flutter-autoroll mentioned this pull request Apr 16, 2024

Roll Packages from 6698b2d67999 to 90c876d37619 (7 revisions) flutter/flutter#146835

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 16, 2024

9a24904 [image_picker] Adopt code excerpts in README (flutter/package…

72cd906

…s#5523)

Conversation

mike-v2 commented Nov 30, 2023

Pre-launch Checklist

Uh oh!

mike-v2 commented Nov 30, 2023

Uh oh!

mike-v2 commented Nov 30, 2023

Uh oh!

stuartmorgan-g Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

ditman Jan 5, 2024

Choose a reason for hiding this comment

Uh oh!

mike-v2 commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented Jan 30, 2024

Uh oh!

stuartmorgan-g commented Mar 5, 2024

Uh oh!

ditman commented Apr 12, 2024

Uh oh!

ditman commented Apr 12, 2024

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Apr 15, 2024

Uh oh!

stuartmorgan-g commented Apr 15, 2024

Uh oh!

auto-submit bot commented Apr 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mike-v2 commented Jan 9, 2024 •

edited

Loading