[image_picker_for_web] migrates to package:web#5799
Merged
auto-submit[bot] merged 45 commits intoflutter:mainfrom Mar 6, 2024
Merged
[image_picker_for_web] migrates to package:web#5799auto-submit[bot] merged 45 commits intoflutter:mainfrom
auto-submit[bot] merged 45 commits intoflutter:mainfrom
Conversation
balvinderz
commented
Jan 4, 2024
...es/image_picker/image_picker_for_web/example/integration_test/image_picker_for_web_test.dart
Outdated
Show resolved
Hide resolved
balvinderz
commented
Jan 4, 2024
...es/image_picker/image_picker_for_web/example/integration_test/image_picker_for_web_test.dart
Outdated
Show resolved
Hide resolved
…web' into migrate_image_picker_to_package_web
kevmoo
reviewed
Feb 28, 2024
ditman
approved these changes
Feb 29, 2024
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
PTAL @tarrinneal, I think I addressed all my own concerns haha!
Member
|
(I tried compiling the example app to Wasm, but it depends on |
kevmoo
reviewed
Mar 5, 2024
packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
Show resolved
Hide resolved
kevmoo
reviewed
Mar 5, 2024
packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
Show resolved
Hide resolved
kevmoo
reviewed
Mar 5, 2024
packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
Outdated
Show resolved
Hide resolved
kevmoo
reviewed
Mar 5, 2024
| /// Converts a [web.FileList] into a [List] of [web.File]. | ||
| /// | ||
| /// This method makes a copy. | ||
| List<web.File> get toList => |
Contributor
There was a problem hiding this comment.
meh...I'd opt for a function here. But maybe that's just my preference.
Member
There was a problem hiding this comment.
I hope this eventually gets provided by package:web, as some form of iterable thing, so I don't need any of my code :P
kevmoo
approved these changes
Mar 5, 2024
ditman
reviewed
Mar 6, 2024
packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
Show resolved
Hide resolved
ditman
reviewed
Mar 6, 2024
packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
Outdated
Show resolved
Hide resolved
ditman
reviewed
Mar 6, 2024
packages/image_picker/image_picker_for_web/lib/src/image_resizer.dart
Outdated
Show resolved
Hide resolved
ditman
reviewed
Mar 6, 2024
| // Observe the input until we can return something | ||
| input.onChange.first.then((html.Event event) { | ||
| final List<html.File>? files = _handleOnChangeEvent(event); | ||
| input.onchange = (web.Event event) { |
Member
There was a problem hiding this comment.
Use the streams, not the listeners directly.
Member
There was a problem hiding this comment.
Created an issue for this, the onCancel stream doesn't exist and seems that cannot be easily created: dart-lang/web#199
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 6, 2024
flutter/packages@2aa6e3f...9b88dbc 2024-03-06 [email protected] [image_picker_for_web] migrates to package:web (flutter/packages#5799) 2024-03-06 [email protected] [video_player_web] migrates to package:web (flutter/packages#5800) 2024-03-06 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20240205 to 20240303 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#6253) 2024-03-05 [email protected] [rfw] Change test coverage logic to enforce 100% coverage (flutter/packages#6272) 2024-03-05 [email protected] [in_app_purchase_storekit] backfill native tests for more complete test coverage (flutter/packages#6209) 2024-03-05 [email protected] [tool] Add features to support GCB auto-publish flow (flutter/packages#6218) 2024-03-05 [email protected] [web] Use TrustedTypes from pkg web. (flutter/packages#6273) 2024-03-05 [email protected] Roll Flutter from 65cd84b to 3b5a2ec (26 revisions) (flutter/packages#6269) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
Updates the web implementation of `image_picker_for_web` to `package:web`. ### Issues * Fixes flutter/flutter#139751
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the web implementation of
image_picker_for_webtopackage:web.Issues
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.